mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: jt@hpl.hp.com
Cc: rutt@chezrutt.com (John Ruttenberg),
	linux-kernel@vger.kernel.org (Linux kernel mailing list),
	alan@lxorguk.ukuu.org.uk (Alan Cox)
Subject: Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)
Date: Tue, 9 Jan 2001 17:13:42 +0000 (GMT)	[thread overview]
Message-ID: <E14G2LB-0006zy-00@the-village.bc.nu> (raw)
In-Reply-To: <20010109090427.A30175@bougret.hpl.hp.com> from "Jean Tourrilhes" at Jan 09, 2001 09:04:27 AM

> 	This is a bug with the definition of udelay(). Somebody tried
> to be too clever with udelay(), and the end result is that it breaks
> perfectly good and valid code.
> 	Therefore, it should be reported as such on LKML, a bug in udelay().

It is a bug in the driver.

> there. For my part, I insist that the code is correct, that replacing
> an inline function by a #define is going backwards and that udelay()
> should be fixed one way or another (easy, just define __bad_udelay()
> as returning a compilation warning or an error message).

You can't #define a function to a #warning or #error in C. Language limitation

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2001-01-09 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200101091217.f09CH1n01252@mojo.chezrutt.com>
2001-01-09 17:04 ` Jean Tourrilhes
2001-01-09 17:13   ` Alan Cox [this message]
2001-01-09 17:42     ` Jean Tourrilhes
2001-01-09 17:48       ` Alan Cox
2001-01-09 17:58         ` Jean Tourrilhes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E14G2LB-0006zy-00@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=jt@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rutt@chezrutt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®