From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: "J . A . Magallon" <jamagallon@able.es>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: aic7xxx funcs without return values
Date: Wed, 07 Mar 2001 17:53:51 -0700 [thread overview]
Message-ID: <200103080053.f280rpO33821@aslan.scsiguy.com> (raw)
In-Reply-To: Your message of "Thu, 08 Mar 2001 01:21:49 +0100." <20010308012149.A1158@werewolf.able.es>
>Hi,
>
>Just a note to make gcc 2.96 (and future) happy. The aic7xxx driver is full of
>inline funcs that should return a value and do not do that:
They don't return a value because doing so is meaningless. You aren't
going to get past the panic. The compiler should know that assuming
panic is properly tagged as a function that cannot return.
You may also want to check up on your C since having a break after
a return is, well, kinda silly. In all the usage of this inline, the
width is constant, so gcc should completely optimize away the switch
and surrounding code.
--
Justin
next prev parent reply other threads:[~2001-03-08 0:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-08 0:21 J . A . Magallon
2001-03-08 0:53 ` Justin T. Gibbs [this message]
2001-03-08 11:56 ` Alan Cox
2001-03-08 18:53 ` Justin T. Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200103080053.f280rpO33821@aslan.scsiguy.com \
--to=gibbs@scsiguy.com \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®