From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: gibbs@scsiguy.com (Justin T. Gibbs)
Cc: jamagallon@able.es (J . A . Magallon),
linux-kernel@vger.kernel.org (Linux Kernel)
Subject: Re: aic7xxx funcs without return values
Date: Thu, 8 Mar 2001 11:56:32 +0000 (GMT) [thread overview]
Message-ID: <E14az23-0002ot-00@the-village.bc.nu> (raw)
In-Reply-To: <200103080053.f280rpO33821@aslan.scsiguy.com> from "Justin T. Gibbs" at Mar 07, 2001 05:53:51 PM
> They don't return a value because doing so is meaningless. You aren't
> going to get past the panic. The compiler should know that assuming
> panic is properly tagged as a function that cannot return.
>
> You may also want to check up on your C since having a break after
> a return is, well, kinda silly. In all the usage of this inline, the
> width is constant, so gcc should completely optimize away the switch
> and surrounding code.
Yep.
The bigger problem with that driver for pedants is that it contains globals with
names like 'hard_error' which are asking for clashes . Bizarrely all
the static functions are carefully named ahc_* and the globals are called
things like 'restart_squencer'
The EISA probe code is also horrible, but thats not Justin's fault. Someone
needs to put some eisa_* bus functions into the kernel for that and some
of the other drivers.
next prev parent reply other threads:[~2001-03-08 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-08 0:21 J . A . Magallon
2001-03-08 0:53 ` Justin T. Gibbs
2001-03-08 11:56 ` Alan Cox [this message]
2001-03-08 18:53 ` Justin T. Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E14az23-0002ot-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=gibbs@scsiguy.com \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®