mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jamagallon@able.es (J . A . Magallon),
	linux-kernel@vger.kernel.org (Linux Kernel)
Subject: Re: aic7xxx funcs without return values
Date: Thu, 08 Mar 2001 11:53:53 -0700	[thread overview]
Message-ID: <200103081853.f28IrrO43186@aslan.scsiguy.com> (raw)
In-Reply-To: Your message of "Thu, 08 Mar 2001 11:56:32 GMT." <E14az23-0002ot-00@the-village.bc.nu>

>The bigger problem with that driver for pedants is that it contains globals
>with names like 'hard_error' which are asking for clashes . Bizarrely all
>the static functions are carefully named ahc_* and the globals are called
>things like 'restart_squencer'

Such is the evolutionary nature of most drivers.  I just spent a bit
of time cleaning this up.  Some of the exported symbols didn't even
need to be in the current layout of the driver.

Thanks for the reminder.
Justin

      reply	other threads:[~2001-03-08 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-08  0:21 J . A . Magallon
2001-03-08  0:53 ` Justin T. Gibbs
2001-03-08 11:56   ` Alan Cox
2001-03-08 18:53     ` Justin T. Gibbs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200103081853.f28IrrO43186@aslan.scsiguy.com \
    --to=gibbs@scsiguy.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®