mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Ulrich.Weigand@de.ibm.com
Cc: linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com,
	utz.bacher@de.ibm.com
Subject: Re: Bug in tcp_v4_hnd_req?
Date: Wed, 26 Sep 2001 16:39:46 -0700 (PDT)	[thread overview]
Message-ID: <20010926.163946.11595354.davem@redhat.com> (raw)
In-Reply-To: <OF9A5AA6CF.110D18E7-ONC1256AD3.0080234F@de.ibm.com>
In-Reply-To: <OF9A5AA6CF.110D18E7-ONC1256AD3.0080234F@de.ibm.com>

   From: "Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>
   Date: Thu, 27 Sep 2001 01:27:33 +0200

   the following code in tcp_v4_hnd_req looks broken:
   
 ...
             tcp_tw_put((struct tcp_tw_bucket*)sk);
   
   Shouldn't it put *nsk* instead of sk?  This appears to be the cause of
   weird crashes under heavy network load we've been experiencing ...

Indeed, you are correct and I've also made the fix for ipv6 in my tree
as it had the same exact problem.

Franks a lot,
David S. Miller
davem@redhat.com

      reply	other threads:[~2001-09-26 23:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-26 23:27 Ulrich Weigand
2001-09-26 23:39 ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010926.163946.11595354.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=utz.bacher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®