* Bug in tcp_v4_hnd_req?
@ 2001-09-26 23:27 Ulrich Weigand
2001-09-26 23:39 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Weigand @ 2001-09-26 23:27 UTC (permalink / raw)
To: davem; +Cc: linux-kernel, Martin Schwidefsky, Utz Bacher
Hello,
the following code in tcp_v4_hnd_req looks broken:
if (nsk) {
if (nsk->state != TCP_TIME_WAIT) {
bh_lock_sock(nsk);
return nsk;
}
tcp_tw_put((struct tcp_tw_bucket*)sk);
return NULL;
}
Shouldn't it put *nsk* instead of sk? This appears to be the cause of
weird crashes under heavy network load we've been experiencing ...
Mit freundlichen Gruessen / Best Regards
Ulrich Weigand
--
Dr. Ulrich Weigand
Linux for S/390 Design & Development
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
Phone: +49-7031/16-3727 --- Email: Ulrich.Weigand@de.ibm.com
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Bug in tcp_v4_hnd_req?
2001-09-26 23:27 Bug in tcp_v4_hnd_req? Ulrich Weigand
@ 2001-09-26 23:39 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2001-09-26 23:39 UTC (permalink / raw)
To: Ulrich.Weigand; +Cc: linux-kernel, schwidefsky, utz.bacher
From: "Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>
Date: Thu, 27 Sep 2001 01:27:33 +0200
the following code in tcp_v4_hnd_req looks broken:
...
tcp_tw_put((struct tcp_tw_bucket*)sk);
Shouldn't it put *nsk* instead of sk? This appears to be the cause of
weird crashes under heavy network load we've been experiencing ...
Indeed, you are correct and I've also made the fix for ipv6 in my tree
as it had the same exact problem.
Franks a lot,
David S. Miller
davem@redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-09-26 23:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-09-26 23:27 Bug in tcp_v4_hnd_req? Ulrich Weigand
2001-09-26 23:39 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®