mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>
To: davem@redhat.com
Cc: linux-kernel@vger.kernel.org,
	"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
	"Utz Bacher" <utz.bacher@de.ibm.com>
Subject: Bug in tcp_v4_hnd_req?
Date: Thu, 27 Sep 2001 01:27:33 +0200	[thread overview]
Message-ID: <OF9A5AA6CF.110D18E7-ONC1256AD3.0080234F@de.ibm.com> (raw)

Hello,

the following code in tcp_v4_hnd_req looks broken:

     if (nsk) {
          if (nsk->state != TCP_TIME_WAIT) {
               bh_lock_sock(nsk);
               return nsk;
          }
          tcp_tw_put((struct tcp_tw_bucket*)sk);
          return NULL;
     }

Shouldn't it put *nsk* instead of sk?  This appears to be the cause of
weird crashes under heavy network load we've been experiencing ...


Mit freundlichen Gruessen / Best Regards

Ulrich Weigand

--
  Dr. Ulrich Weigand
  Linux for S/390 Design & Development
  IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
  Phone: +49-7031/16-3727   ---   Email: Ulrich.Weigand@de.ibm.com


             reply	other threads:[~2001-09-26 23:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-26 23:27 Ulrich Weigand [this message]
2001-09-26 23:39 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF9A5AA6CF.110D18E7-ONC1256AD3.0080234F@de.ibm.com \
    --to=ulrich.weigand@de.ibm.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=utz.bacher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®