[PATCH] Fix check if device is ethernet in alloc_divert_blk

[PATCH] Fix check if device is ethernet in alloc_divert_blk

[Guus Sliepen]

[-- Attachment #1.1: Type: text/plain, Size: 583 bytes --]

Hello,

I was wondering why various devices like 802.11 bridges and tap devices
weren't recognized by the kernel as ethernet devices, because I got
messages like this in my syslog:

Oct 30 15:35:52 haplo kernel: divert: not allocating divert_blk for non-ethernet device bla

Instead of checking for the actual device type, alloc_divert_blk was
just checking if the string "eth" occured in the name of the interface.
Attached patch makes it do the right thing instead (I hope).

-- 
Met vriendelijke groet / with kind regards,
  Guus Sliepen <guus@sliepen.warande.net>

[-- Attachment #1.2: patch_dv --]
[-- Type: text/plain, Size: 369 bytes --]

--- linux-2.4.13.orig/net/core/dv.c	Tue Oct 30 16:09:20 2001
+++ linux-2.4.13/net/core/dv.c	Tue Oct 30 16:09:26 2001
@@ -53,7 +53,7 @@
 {
 	int alloc_size = (sizeof(struct divert_blk) + 3) & ~3;
 
-	if (!strncmp(dev->name, "eth", 3)) {
+	if (dev->type == ARPHRD_ETHER) {
 		printk(KERN_DEBUG "divert: allocating divert_blk for %s\n",
 		       dev->name);
 

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [PATCH] Fix check if device is ethernet in alloc_divert_blk

[David S. Miller]

   From: Guus Sliepen <guus@warande3094.warande.uu.nl>
   Date: Tue, 30 Oct 2001 16:22:35 +0100
   
   Instead of checking for the actual device type, alloc_divert_blk was
   just checking if the string "eth" occured in the name of the interface.
   Attached patch makes it do the right thing instead (I hope).

I've applied your patch.

Franks a lot,
David S. Miller
davem@redhat.com