From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: Andrew Morton <akpm@zip.com.au>
Cc: timothy.covell@ashavan.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
support@redhat.com
Subject: Re: Fwd: Hard Lockup on 2.4.16 with Via ieee1394 (sbp2 mode)
Date: Fri, 28 Dec 2001 20:40:41 -0800 [thread overview]
Message-ID: <20011228204041.A14736@one-eyed-alien.net> (raw)
In-Reply-To: <200112290321.fBT3GCSs007627@svr3.applink.net> <3C2D3DBB.6ADE1CC5@zip.com.au>
In-Reply-To: <3C2D3DBB.6ADE1CC5@zip.com.au>; from akpm@zip.com.au on Fri, Dec 28, 2001 at 07:51:23PM -0800
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
Hrm...
Does this apply to usb-storage also? Under what conditions do you need to
hold the io_request_lock when calling the done function?
usb-storage calls it from task context, not from IRQ context.... if that
makes any difference.
Matt
On Fri, Dec 28, 2001 at 07:51:23PM -0800, Andrew Morton wrote:
> Timothy Covell wrote:
> >
> > lockup
> > ...
> > sbp2
> > ...
> > SMP
> > ...
>
> --- linux-2.4.17-pre8/drivers/ieee1394/sbp2.c Mon Dec 10 13:46:20 2001
> +++ linux-akpm/drivers/ieee1394/sbp2.c Wed Dec 12 20:50:16 2001
> @@ -2773,7 +2773,9 @@ static void sbp2scsi_complete_command(st
> /*
> * Tell scsi stack that we're done with this command
> */
> + spin_lock_irq(&io_request_lock);
> done (SCpnt);
> + spin_unlock_irq(&io_request_lock);
>
> return;
> }
>
> -
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
Da. Am thinkink of carbonated borscht for lonk nights of coding.
-- Pitr
User Friendly, 7/24/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
next prev parent reply other threads:[~2001-12-29 4:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-29 3:13 Timothy Covell
2001-12-29 3:51 ` Andrew Morton
2001-12-29 4:40 ` Matthew Dharm [this message]
2001-12-29 4:59 ` Andrew Morton
2001-12-29 5:11 ` Matthew Dharm
2001-12-29 6:17 ` Timothy Covell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011228204041.A14736@one-eyed-alien.net \
--to=mdharm-kernel@one-eyed-alien.net \
--cc=akpm@zip.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=support@redhat.com \
--cc=timothy.covell@ashavan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome