From: Timothy Covell <timothy.covell@ashavan.org>
To: Andrew Morton <akpm@zip.com.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: Hard Lockup on 2.4.16 with Via ieee1394 (sbp2 mode)
Date: Sat, 29 Dec 2001 00:17:57 -0600 [thread overview]
Message-ID: <200112290621.fBT6LeSr007977@svr3.applink.net> (raw)
In-Reply-To: <200112290321.fBT3GCSs007627@svr3.applink.net> <3C2D3DBB.6ADE1CC5@zip.com.au>
In-Reply-To: <3C2D3DBB.6ADE1CC5@zip.com.au>
On Friday 28 December 2001 21:51, you wrote:
> Timothy Covell wrote:
> > lockup
> > ...
> > sbp2
> > ...
> > SMP
> > ...
>
> --- linux-2.4.17-pre8/drivers/ieee1394/sbp2.c Mon Dec 10 13:46:20 2001
> +++ linux-akpm/drivers/ieee1394/sbp2.c Wed Dec 12 20:50:16 2001
> @@ -2773,7 +2773,9 @@ static void sbp2scsi_complete_command(st
> /*
> * Tell scsi stack that we're done with this command
> */
> + spin_lock_irq(&io_request_lock);
> done (SCpnt);
> + spin_unlock_irq(&io_request_lock);
>
> return;
> }
>
>
That did the trick. I'm writing this on 2.4.16-ctx4 with this patch on SMP.
It's amazing what a little spin lock will do. Thanks!
(Even if I had realized that this was fixed on 2.4.17, I had other issues
with 2.4.17 which prevented me from wanting to run it.)
timothy.covell@ashavan.org.
prev parent reply other threads:[~2001-12-29 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-29 3:13 Timothy Covell
2001-12-29 3:51 ` Andrew Morton
2001-12-29 4:40 ` Matthew Dharm
2001-12-29 4:59 ` Andrew Morton
2001-12-29 5:11 ` Matthew Dharm
2001-12-29 6:17 ` Timothy Covell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200112290621.fBT6LeSr007977@svr3.applink.net \
--to=timothy.covell@ashavan.org \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®