* Re: Linux 2.4.18-pre4 bonding driver...
[not found] ` <15430.2169.508178.665820@charged.uio.no>
@ 2002-01-17 21:15 ` Trond Myklebust
2002-01-21 18:37 ` Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Trond Myklebust @ 2002-01-17 21:15 UTC (permalink / raw)
To: marcelo; +Cc: Linux Kernel
Marcelo,
Is this code from linux-2.4.18-pre4/drivers/net/bonding.c safe?
static int bond_close(struct net_device *master)
{
write_lock_irqsave(&bond->lock, flags);
<snip>
bond_release_all(master);
write_unlock_irqrestore(&bond->lock, flags);
AFAICS 'bond_release_all()' calls a bunch of lower level networking
functions some of which do sleep. It does nothing to release the
bond->lock when this occurs.
Cheers,
Trond
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Linux 2.4.18-pre4 bonding driver...
2002-01-17 21:15 ` Linux 2.4.18-pre4 bonding driver Trond Myklebust
@ 2002-01-21 18:37 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2002-01-21 18:37 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Linux Kernel
On Thu, 17 Jan 2002, Trond Myklebust wrote:
>
> Marcelo,
>
> Is this code from linux-2.4.18-pre4/drivers/net/bonding.c safe?
>
> static int bond_close(struct net_device *master)
> {
> write_lock_irqsave(&bond->lock, flags);
> <snip>
> bond_release_all(master);
>
> write_unlock_irqrestore(&bond->lock, flags);
>
> AFAICS 'bond_release_all()' calls a bunch of lower level networking
> functions some of which do sleep. It does nothing to release the
> bond->lock when this occurs.
They are not safe, indeed.
Have you tried to contact the driver authors ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Linux 2.4.18-pre4 bonding driver...
[not found] <200201162351.AAA24092@webserver.ithnet.com>
[not found] ` <15430.2169.508178.665820@charged.uio.no>
@ 2002-01-17 21:39 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2002-01-17 21:39 UTC (permalink / raw)
To: trond.myklebust; +Cc: marcelo, linux-kernel
From: Trond Myklebust <trond.myklebust@fys.uio.no>
Date: Thu, 17 Jan 2002 22:15:00 +0100
Is this code from linux-2.4.18-pre4/drivers/net/bonding.c safe?
We don't know, ask the Bonding maintainers as they asked us to merge
in these updates for them.
Franks a lot,
David S. Miller
davem@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-01-21 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200201162351.AAA24092@webserver.ithnet.com>
[not found] ` <15430.2169.508178.665820@charged.uio.no>
2002-01-17 21:15 ` Linux 2.4.18-pre4 bonding driver Trond Myklebust
2002-01-21 18:37 ` Marcelo Tosatti
2002-01-17 21:39 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®