[PATCH RFC] SiS 2.4 IDE driver update (+= ATA16|ATA33|ATA100)

[PATCH RFC] SiS 2.4 IDE driver update (+= ATA16|ATA33|ATA100)

[Lionel Bouton]

Hello,

New driver for SiS IDE chipsets with support for ATA16 to ATA100
chip generations.
I added support for ATAT16 and ATA33 chipsets to my previous patches and
rewrote large parts of the original driver.
The diff is 33345 bytes long (longer than the whole sis5513.c file in fact)
so I put it on a web server (thanks go to my employer for the web hosting):

http://inet6.dyn.dhs.org/sponsoring/sis5513/sis.patch.20020123_1

On the following page you'll find more information, links to current
sis5513.c code and previous patches:
http://inet6.dyn.dhs.org/sponsoring/sis5513/index.html

As always, success and failure reports are welcomed.
Comments on coding style are too.

LB.

Re: [PATCH RFC] SiS 2.4 IDE driver update (+= ATA16|ATA33|ATA100)

[Liakakis Kostas]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 527 bytes --]


Well, success :-)
Stock 2.4.17 doesn't hang any more :-)

One question though, hdparm -i/I says my drive is udma2 (UDMA/33 isnt it?)
capable. Why don't I get it on boot? (or is my chipset UDMA/33 capable?).
hdparm -X66 /dev/hda hangs the machine completely. Same with 65 and 64.
The debug messages that appear when I do so say:

sis5513_tune_chipset start, changed registers: none 
sis5513_tune_chipset ,drive 0, speed 66
sis5513_tune_chipset end, changed registers: none

Attached is the boot time debug info.

Thanks,

-K.


[-- Attachment #2: Type: TEXT/PLAIN, Size: 1442 bytes --]

ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
SIS5513: IDE controller on PCI bus 00 dev 09
PCI: Assigned IRQ 14 for device 00:01.1
SIS5513: chipset revision 208
SIS5513: not 100% native mode: will probe irqs later
SIS5513 pci_init_sis5513 start
SIS5513 dump:
              0x0:0x39 0x1:0x10 0x2:0x13 0x3:0x55 0x4:0x7 0x5:0x0 0x6:0x0 0x7:0x0 0x8:0xd0 0x9:0x8a 0xa:0x1 0xb:0x1 0xc:0x0 0xd:0x40 0xe:0x80 0xf:0x0
              0x10:0xf1 0x11:0x1 0x12:0x0 0x13:0x0 0x14:0xf5 0x15:0x3 0x16:0x0 0x17:0x0 0x18:0x71 0x19:0x1 0x1a:0x0 0x1b:0x0 0x1c:0x75 0x1d:0x3 0x1e:0x0 0x1f:0x0
              0x20:0x1 0x21:0x40 0x22:0x0 0x23:0x0 0x24:0x0 0x25:0x0 0x26:0x0 0x27:0x0 0x28:0x0 0x29:0x0 0x2a:0x0 0x2b:0x0 0x2c:0x0 0x2d:0x0 0x2e:0x0 0x2f:0x0
              0x30:0x0 0x31:0x0 0x32:0x0 0x33:0x0 0x34:0x0 0x35:0x0 0x36:0x0 0x37:0x0 0x38:0x0 0x39:0x0 0x3a:0x0 0x3b:0x0 0x3c:0xe 0x3d:0x1 0x3e:0x0 0x3f:0x0
              0x40:0x1 0x41:0xa3 0x42:0x0 0x43:0x0 0x44:0x0 0x45:0x0 0x46:0x0 0x47:0x0 0x48:0x0 0x49:0x7 0x4a:0xa6 0x4b:0xff 0x4c:0x0 0x4d:0x2 0x4e:0x0 0x4f:0x2
SiS5513
SIS5513: pci_init_sis5513 end, changed registers:
none
    ide0: BM-DMA at 0x4000-0x4007, BIOS settings: hda:pio, hdb:pio
    ide1: BM-DMA at 0x4008-0x400f, BIOS settings: hdc:pio, hdd:pio
hda: ST34321A, ATA DISK drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
hda: 8404830 sectors (4303 MB) w/128KiB Cache, CHS=523/255/63
Partition check:

Re: [PATCH RFC] SiS 2.4 IDE driver update (+= ATA16|ATA33|ATA100)

[Lionel Bouton]

On Fri, Jan 25, 2002 at 08:02:43PM +0200, Liakakis Kostas wrote:
> 
> Well, success :-)
> Stock 2.4.17 doesn't hang any more :-)
> 

Cool.

> One question though, hdparm -i/I says my drive is udma2 (UDMA/33 isnt it?)
> capable. Why don't I get it on boot? (or is my chipset UDMA/33 capable?).

Don't think so. IIRC (don't have the specs right now at hand) SiS5513 isn't UDMA capable.

> hdparm -X66 /dev/hda hangs the machine completely. Same with 65 and 64.

If I'm correct with UDMA above, this is expected behavior...
I don't know the IDE framework and hdparm enough yet to know if I can trap hdparm
actions at the chip driver level... it may speak (and I believe it to do so) to the drives directly.

> The debug messages that appear when I do so say:
> 
> sis5513_tune_chipset start, changed registers: none 
> sis5513_tune_chipset ,drive 0, speed 66
> sis5513_tune_chipset end, changed registers: none
> 
> Attached is the boot time debug info.

Many thanks. My database of BIOS init behaviour will grow, this is *good*.

I'm mostly away (Palm with GSM is kind of... slow) from Net access this week-end and I'll be away too from tuesday
on next week. So don't be surprised if I don't answer bug reports or
enhancement requests in the following days, be patient and don't hesitate
to repost your message if you don't have any answer February the 6.

LB.