CONFIG_SERIAL_ACPI and early_serial_setup

CONFIG_SERIAL_ACPI and early_serial_setup

[Geert Uytterhoeven]

If CONFIG_SERIAL_ACPI=y, but CONFIG_SERIAL=m, the kernel (2.4.18-pre9) doesn't
link because early_serial_setup() is not found.

I think the correct fix is to not allow CONFIG_SERIAL_ACPI, unless
CONFIG_SERIAL=y.

--- linux-tux-2.4.18-pre9/drivers/char/Config.in.orig	Fri Feb  8 09:38:36 2002
+++ linux-tux-2.4.18-pre9/drivers/char/Config.in	Fri Feb  8 13:23:25 2002
@@ -15,9 +15,9 @@
       tristate '   Atomwide serial port support' CONFIG_ATOMWIDE_SERIAL
       tristate '   Dual serial port support' CONFIG_DUALSP_SERIAL
    fi
-fi
-if [ "$CONFIG_ACPI" = "y" ]; then
-   bool '  Support for serial ports defined by ACPI tables' CONFIG_SERIAL_ACPI
+   if [ "$CONFIG_ACPI" = "y" ]; then
+      bool '  Support for serial ports defined by ACPI tables' CONFIG_SERIAL_ACPI
+   fi
 fi
 dep_mbool 'Extended dumb serial driver options' CONFIG_SERIAL_EXTENDED $CONFIG_SERIAL
 if [ "$CONFIG_SERIAL_EXTENDED" = "y" ]; then

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: CONFIG_SERIAL_ACPI and early_serial_setup

[Dave Jones]

On Fri, Feb 08, 2002 at 01:25:07PM +0100, Geert Uytterhoeven wrote:
 > 
 > If CONFIG_SERIAL_ACPI=y, but CONFIG_SERIAL=m, the kernel (2.4.18-pre9) doesn't
 > link because early_serial_setup() is not found.
 > 
 > I think the correct fix is to not allow CONFIG_SERIAL_ACPI, unless
 > CONFIG_SERIAL=y.

 Isn't CONFIG_SERIAL_ACPI an ia64 only option ?

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

Re: CONFIG_SERIAL_ACPI and early_serial_setup

[Geert Uytterhoeven]

On Fri, 8 Feb 2002, Dave Jones wrote:
> On Fri, Feb 08, 2002 at 01:25:07PM +0100, Geert Uytterhoeven wrote:
>  > If CONFIG_SERIAL_ACPI=y, but CONFIG_SERIAL=m, the kernel (2.4.18-pre9) doesn't
>  > link because early_serial_setup() is not found.
>  > 
>  > I think the correct fix is to not allow CONFIG_SERIAL_ACPI, unless
>  > CONFIG_SERIAL=y.
> 
>  Isn't CONFIG_SERIAL_ACPI an ia64 only option ?

It's not protected by a test for ia64, only by a test for CONFIG_ACPI, and its
Configure.help entry didn't tell me anything suspicious, so I enabled it for my
Vaio.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: CONFIG_SERIAL_ACPI and early_serial_setup

[Pavel Machek]

Hi!

>  > If CONFIG_SERIAL_ACPI=y, but CONFIG_SERIAL=m, the kernel (2.4.18-pre9) doesn't
>  > link because early_serial_setup() is not found.
>  > 
>  > I think the correct fix is to not allow CONFIG_SERIAL_ACPI, unless
>  > CONFIG_SERIAL=y.
> 
>  Isn't CONFIG_SERIAL_ACPI an ia64 only option ?

No, AFAIK.
									Pavel
-- 
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa