Re: [PATCH] automatic initcalls

[Rusty Russell <rusty@rustcorp.com.au>]

In message <3D430123.739CA34D@linux-m68k.org> you write:
> - I only look at modules which contain an initcall
> - I only order initcalls of level 6 and 7

You don't seem to handle the ordering of initcalls within a module
though: see net/ipv4/netfilter/ip_conntrack.o for an example of
multiple inits which would be much better as separate initcalls.

The more I play with these magic approaches, the more I prefer an
explicit "Must be done after this" and "must be done before this":
otherwise we're going to need to keep adding new levels as we discover
something that doesn't fit in the magic 7.

Especially since you don't cover any of the really interesting cases.
Maybe if you could slowly extend it to cover the rest?  (Hah, I
know!).

> +init/generated-initcalls.c: .allinit.defs
> +	set -e; echo '#include <linux/init.h>' > $@; \
> +	sed -n < $< "s,^T ,,p" | sort > .defined.all; \

I think you mean something like:

	sed -n "s,^T ,,p" < $<

> -__initcall(spawn_ksoftirqd);
> +fs_initcall(spawn_ksoftirqd);

See, this is exacly the kind of thing that makes me doubt that the
current "magic 7 initcall levels" are useful in the long term 8(

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.