Re: [PATCH] automatic initcalls

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Sun, 28 Jul 2002, Rusty Russell wrote:

> > - I only look at modules which contain an initcall
> > - I only order initcalls of level 6 and 7
>
> You don't seem to handle the ordering of initcalls within a module
> though: see net/ipv4/netfilter/ip_conntrack.o for an example of
> multiple inits which would be much better as separate initcalls.

Actually I'm most interested in ordering "module_init()" and you can have
only one of them per module or how do you want to implement multiple
initcalls per module?

> Especially since you don't cover any of the really interesting cases.
> Maybe if you could slowly extend it to cover the rest?  (Hah, I
> know!).

I wouldn't mind if the remaining initcalls are converted to explicit
dependencies, but it's possible to sort automatically everything that can
be built as modules.

> > +init/generated-initcalls.c: .allinit.defs
> > +	set -e; echo '#include <linux/init.h>' > $@; \
> > +	sed -n < $< "s,^T ,,p" | sort > .defined.all; \
>
> I think you mean something like:
>
> 	sed -n "s,^T ,,p" < $<

Isn't that the same?

bye, Roman