From: David Mosberger <davidm@napali.hpl.hp.com>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, davidm@napali.hpl.hp.com
Subject: adjust prefetch in free_one_pgd()
Date: Thu, 1 Aug 2002 17:12:39 -0700 [thread overview]
Message-ID: <200208020012.g720CdeJ017016@napali.hpl.hp.com> (raw)
As per an earlier discussion on the lkml, the existing prefetch in
free_one_pgd() is somewhat broken in that it prefetches further than
PREFETCH_STRIDE bytes. The patch below fixes that. I'm told that
this also performs better on x86 (it makes little difference on ia64,
but it is also marginally better).
--david
diff -Nru a/mm/memory.c b/mm/memory.c
--- a/mm/memory.c Thu Aug 1 17:02:14 2002
+++ b/mm/memory.c Thu Aug 1 17:02:14 2002
@@ -110,7 +110,7 @@
pmd = pmd_offset(dir, 0);
pgd_clear(dir);
for (j = 0; j < PTRS_PER_PMD ; j++) {
- prefetchw(pmd+j+(PREFETCH_STRIDE/16));
+ prefetchw(pmd + j + PREFETCH_STRIDE/sizeof(*pmd));
free_one_pmd(tlb, pmd+j);
}
pmd_free_tlb(tlb, pmd);
next reply other threads:[~2002-08-02 0:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-02 0:12 David Mosberger [this message]
2002-08-02 13:04 ` Alan Cox
2002-08-02 15:39 ` David Mosberger
2002-08-02 15:46 ` Linus Torvalds
2002-08-02 15:56 ` Dave Jones
2002-08-02 15:59 ` Linus Torvalds
2002-08-02 16:04 ` Dave Jones
2002-08-02 17:49 ` Alan Cox
2002-08-02 16:38 ` David Mosberger
2002-08-02 17:58 ` Alan Cox
2002-08-02 16:53 ` David Mosberger
2002-08-03 16:59 ` David Woodhouse
2002-08-03 17:22 ` Linus Torvalds
2002-08-03 17:39 ` David Woodhouse
2002-08-03 19:36 ` Linus Torvalds
2002-08-03 22:03 ` David Woodhouse
2002-08-03 22:40 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200208020012.g720CdeJ017016@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®