input u-cleanup

input u-cleanup

[Pavel Machek]

Hi!

proc is clever enough not to need ifdefs, so this is probably good
idea...

								Pavel

--- clean/drivers/input/input.c	Wed Aug 28 22:38:46 2002
+++ linux-swsusp/drivers/input/input.c	Wed Aug 28 23:28:23 2002
@@ -800,11 +803,9 @@
 
 static void __exit input_exit(void)
 {
-#ifdef CONFIG_PROC_FS
 	remove_proc_entry("devices", proc_bus_input_dir);
 	remove_proc_entry("handlers", proc_bus_input_dir);
 	remove_proc_entry("input", proc_bus);
-#endif
 	devfs_unregister(input_devfs_handle);
         if (unregister_chrdev(INPUT_MAJOR, "input"))
                 printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR);

-- 
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?

Re: input u-cleanup

[Vojtech Pavlik]

On Thu, Aug 29, 2002 at 12:06:03AM +0200, Pavel Machek wrote:
> Hi!
> 
> proc is clever enough not to need ifdefs, so this is probably good
> idea...
> 
> 								Pavel

If you could remove all the procfs #ifdefs from input.c, that'd be great.
But removing only those around unregistration IMHO doesn't make sense.

> 
> --- clean/drivers/input/input.c	Wed Aug 28 22:38:46 2002
> +++ linux-swsusp/drivers/input/input.c	Wed Aug 28 23:28:23 2002
> @@ -800,11 +803,9 @@
>  
>  static void __exit input_exit(void)
>  {
> -#ifdef CONFIG_PROC_FS
>  	remove_proc_entry("devices", proc_bus_input_dir);
>  	remove_proc_entry("handlers", proc_bus_input_dir);
>  	remove_proc_entry("input", proc_bus);
> -#endif
>  	devfs_unregister(input_devfs_handle);
>          if (unregister_chrdev(INPUT_MAJOR, "input"))
>                  printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR);
> 
> -- 
> Worst form of spam? Adding advertisment signatures ala sourceforge.net.
> What goes next? Inserting advertisment *into* email?

-- 
Vojtech Pavlik
SuSE Labs

Re: input u-cleanup

[Pavel Machek]

Hi!

> > proc is clever enough not to need ifdefs, so this is probably good
> > idea...
> > 
> > 								Pavel
> 
> If you could remove all the procfs #ifdefs from input.c, that'd be great.
> But removing only those around unregistration IMHO doesn't make
> > sense.


They can be safely dropped. I had patch to do that but droped it during
merge. If you'll accept complete patch, I'll create it.   [Or you can
do it yourself, just killing #ifdef CONFIG_PROC_FS should do the
trick].

 
> > 
> > --- clean/drivers/input/input.c	Wed Aug 28 22:38:46 2002
> > +++ linux-swsusp/drivers/input/input.c	Wed Aug 28 23:28:23 2002
> > @@ -800,11 +803,9 @@
> >  
> >  static void __exit input_exit(void)
> >  {
> > -#ifdef CONFIG_PROC_FS
> >  	remove_proc_entry("devices", proc_bus_input_dir);
> >  	remove_proc_entry("handlers", proc_bus_input_dir);
> >  	remove_proc_entry("input", proc_bus);
> > -#endif
> >  	devfs_unregister(input_devfs_handle);
> >          if (unregister_chrdev(INPUT_MAJOR, "input"))
> >                  printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR);
> > 
> > -- 
> > Worst form of spam? Adding advertisment signatures ala sourceforge.net.
> > What goes next? Inserting advertisment *into* email?
> 

-- 
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.

Re: input u-cleanup

[Vojtech Pavlik]

On Fri, Aug 30, 2002 at 12:26:42AM +0200, Pavel Machek wrote:

> > > proc is clever enough not to need ifdefs, so this is probably good
> > > idea...
> > > 
> > > 								Pavel
> > 
> > If you could remove all the procfs #ifdefs from input.c, that'd be great.
> > But removing only those around unregistration IMHO doesn't make
> > > sense.
> 
> 
> They can be safely dropped. I had patch to do that but droped it during
> merge. If you'll accept complete patch, I'll create it.   [Or you can
> do it yourself, just killing #ifdef CONFIG_PROC_FS should do the
> trick].

Yes, but a lot of functions unneeded without CONFIG_PROC_FS will remain
linked in ... if you manage it down to one #ifdef, just around the
functions, I'll take it.

-- 
Vojtech Pavlik
SuSE Labs