Re: Linux 2.4.20-pre6

Re: Linux 2.4.20-pre6

[Tony Spinillo]

>  o i845G fixes

I just tried 2.4.20-pre6 on my Intel 845GBVL board (845G chipset). 
For the first time DMA is available with the DVD drive, 
without a -ac patch. But UDMA(25) as opposed to UDMA(33) 
with 2.4.20pre5-ac1.Also I got some junk characters in 2.4.20pre6 
when it was probing for IDE devices: 

*****DMESG 2.4.20pre6 snip of the Intel board *****
Uniform Multi-Platform E-IDE driver Revision: 6.31
ide: Assuming 33MHz system bus speed for PIO modes; override with
idebus=xx
ICH4: IDE controller on PCI bus 00 dev f9
PCI: Device 00:1f.1 not available because of resource collisions
PCI: Found IRQ 5 for device 00:1f.1
PCI: Sharing IRQ 5 with 00:1d.2
GARBAGE CHARACTERS HERE: BIOS setup was incomplete.
ICH4: chipset revision 1
ICH4: not 100% native mode: will probe irqs later
    ide0: BM-DMA at 0xffa0-0xffa7, BIOS settings: hda:DMA, hdb:pio
hda: LITEON DVD-ROM LTD-165H, ATAPI CD/DVD-ROM drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
hda: ATAPI 48X DVD-ROM drie, 512kB Cache, UDMA(25)
Uniform CD-ROM driver Revision: 3.12
*******
Here is a Dmesg snip of 2.4.20pre5-ac1 on the Intel Board:
*******
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha1
ide: Assuming 33MHz system bus speed for PIO modes; override with
idebus=xx
ICH4: IDE controller at PCI slot 00:1f.1
PCI: Device 00:1f.1 not available because of resource collisions
PCI: Found IRQ 5 for device 00:1f.1
PCI: Sharing IRQ 5 with 00:1d.2
ICH4: Not fully BIOS configured!
ICH4: chipset revision 1
ICH4: not 100% native mode: will probe irqs later
    ide0: BM-DMA at 0xffa0-0xffa7, BIOS settings: hda:DMA, hdb:pio
hda: LITEON DVD-ROM LTD-165H, ATAPI CD/DVD-ROM drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
hda: ATAPI 48X DVD-ROM drive, 512kB Cache, UDMA(33)
Uniform CD-ROM driver Revision: 3.12
***********
2.4.20-pre6 came up fine with my Gigabyte 845IGX (845G chipset)
equipped machine. (Award BIOS as opposed to Intel's). DMA
started to work with 2.4.20-pre5 on this board. The
latest -ac patches do not work on this machine.

Here are full links to the Intel 845GBVL dmesg and lspci:
http://ac.marywood.edu/tspin/www/dmesg2420pre6.txt
http://ac.marywood.edu/tspin/www/dmesg2420pre5ac1.txt
http://ac.marywood.edu/tspin/www/lspci2420pre6.txt

Thanks! If anyone needs more info, let me know.

Tony


__________________________________________________
Yahoo! - We Remember
9-11: A tribute to the more than 3,000 lives lost
http://dir.remember.yahoo.com/tribute

Linux 2.4.20-pre6 tg3 compile errors

[Steve Mickeler]

Compiling in tg3 support using the tg3.c and tg3.h from 2.4.20-pre6

distro: debian woody

gcc -v
Reading specs from /usr/lib/gcc-lib/i386-linux/2.95.4/specs
gcc version 2.95.4 20011002 (Debian prerelease)

gcc -D__KERNEL__ -I/usr/src/linux-2.4.19/include -Wall -Wstrict-prototypes
-Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer
-pipe -mpreferred-stack-boundary=2 -march=i686   -nostdinc -I
/usr/lib/gcc-lib/i386-linux/2.95.4/include -DKBUILD_BASENAME=tg3  -c -o
tg3.o tg3.c
tg3.c: In function `tg3_rx':
tg3.c:1977: warning: implicit declaration of function `netif_receive_skb'
tg3.c: In function `tg3_poll':
tg3.c:2054: structure has no member named `quota'
tg3.c:2055: structure has no member named `quota'
tg3.c:2060: structure has no member named `quota'
tg3.c:2067: warning: implicit declaration of function `netif_rx_complete'
tg3.c: In function `tg3_interrupt_main_work':
tg3.c:2094: warning: implicit declaration of function
`netif_rx_schedule_prep'
tg3.c:2100: warning: implicit declaration of function
`__netif_rx_schedule'
tg3.c: In function `__tg3_set_rx_mode':
tg3.c:4881: structure has no member named `vlgrp'
tg3.c: In function `tg3_init_one':
tg3.c:6641: structure has no member named `poll'
tg3.c:6642: structure has no member named `weight'
make[3]: *** [tg3.o] Error 1
make[3]: Leaving directory `/usr/src/linux-2.4.19/drivers/net'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/usr/src/linux-2.4.19/drivers/net'
make[1]: *** [_subdir_net] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.19/drivers'
make: *** [_dir_drivers] Error 2


[-] Steve Mickeler [ steve@neptune.ca ]

[|] Todays root password is brought to you by /dev/random

[+] 1024D/9AA80CDF = 4103 9E35 2713 D432 924F  3C2E A7B9 A0FE 9AA8 0CDF

Re: Linux 2.4.20-pre6 tg3 compile errors

[David S. Miller]

   From: Steve Mickeler <steve@neptune.ca>
   Date: Tue, 10 Sep 2002 17:19:53 -0400 (EDT)

   Compiling in tg3 support using the tg3.c and tg3.h from 2.4.20-pre6
 ...   
   tg3.c: In function `tg3_rx':
   tg3.c:1977: warning: implicit declaration of function `netif_receive_skb'

I pretty sure you mispatched your tree.

It's there in 2.4.20-pre6:

bash$ egrep netif_receive_skb patch-2.4.20-pre6 
+                       netif_receive_skb (skb);
+3) instead of netif_rx() we call netif_receive_skb() to pass the skb.
+                       netif_receive_skb(skb);
+       return (polling ? netif_receive_skb(skb) : netif_rx(skb));
+extern int             netif_receive_skb(struct sk_buff *skb);
+int netif_receive_skb(struct sk_buff *skb)
+               netif_receive_skb(skb);
+EXPORT_SYMBOL(netif_receive_skb);
bash$ 

Re: Linux 2.4.20-pre6 tg3 compile errors

[David S. Miller]

   From: Jeff Garzik <jgarzik@mandrakesoft.com>
   Date: Tue, 10 Sep 2002 17:28:43 -0400
   
   did NAPI get removed from 2.4.x again??
   
No Jeff, this guy just mispatched his tree.
Check 2.4.20-pre6, it's all there.

Re: Linux 2.4.20-pre6 tg3 compile errors

[David S. Miller]

   From: Steve Mickeler <steve@neptune.ca>
   Date: Tue, 10 Sep 2002 17:33:15 -0400 (EDT)
   
   Yes, all I patched was tg3.c and tg3.h

That isn't going to work, the current driver uses NAPI
which means you need the rest of the 2.4.20-X networking
bits too.

Re: Linux 2.4.20-pre6 tg3 compile errors

[Jeff Garzik]

Steve Mickeler wrote:
> Compiling in tg3 support using the tg3.c and tg3.h from 2.4.20-pre6
> 
> distro: debian woody
> 
> gcc -v
> Reading specs from /usr/lib/gcc-lib/i386-linux/2.95.4/specs
> gcc version 2.95.4 20011002 (Debian prerelease)


those are the NAPI functions and struct members.

did NAPI get removed from 2.4.x again??

Re: Linux 2.4.20-pre6 tg3 compile errors

[Steve Mickeler]

Yes, all I patched was tg3.c and tg3.h

Thanks.

On Tue, 10 Sep 2002, David S. Miller wrote:

>    From: Steve Mickeler <steve@neptune.ca>
>    Date: Tue, 10 Sep 2002 17:19:53 -0400 (EDT)
>
>    Compiling in tg3 support using the tg3.c and tg3.h from 2.4.20-pre6
>  ...
>    tg3.c: In function `tg3_rx':
>    tg3.c:1977: warning: implicit declaration of function `netif_receive_skb'
>
> I pretty sure you mispatched your tree.
>
> It's there in 2.4.20-pre6:
>
> bash$ egrep netif_receive_skb patch-2.4.20-pre6
> +                       netif_receive_skb (skb);
> +3) instead of netif_rx() we call netif_receive_skb() to pass the skb.
> +                       netif_receive_skb(skb);
> +       return (polling ? netif_receive_skb(skb) : netif_rx(skb));
> +extern int             netif_receive_skb(struct sk_buff *skb);
> +int netif_receive_skb(struct sk_buff *skb)
> +               netif_receive_skb(skb);
> +EXPORT_SYMBOL(netif_receive_skb);
> bash$
>



[-] Steve Mickeler [ steve@neptune.ca ]

[|] Todays root password is brought to you by /dev/random

[+] 1024D/9AA80CDF = 4103 9E35 2713 D432 924F  3C2E A7B9 A0FE 9AA8 0CDF

Re: Linux 2.4.20-pre6 tg3 compile errors

[Steve Mickeler]

Ok, I applied the entire 2.4.20-pre6 and still get compile errors:

gcc -D__KERNEL__ -I/usr/src/test/linux-2.4.20-pre6/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686
-nostdinc -iwithprefix include -DKBUILD_BASENAME=tg3  -c -o tg3.o tg3.c

tg3.c: In function `__tg3_set_rx_mode':
tg3.c:4881: structure has no member named `vlgrp'
make[3]: *** [tg3.o] Error 1
make[3]: Leaving directory `/usr/src/test/linux-2.4.20-pre6/drivers/net'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/usr/src/test/linux-2.4.20-pre6/drivers/net'
make[1]: *** [_subdir_net] Error 2
make[1]: Leaving directory `/usr/src/test/linux-2.4.20-pre6/drivers'
make: *** [_dir_drivers] Error 2


On Tue, 10 Sep 2002, David S. Miller wrote:

>    From: Steve Mickeler <steve@neptune.ca>
>    Date: Tue, 10 Sep 2002 17:33:15 -0400 (EDT)
>
>    Yes, all I patched was tg3.c and tg3.h
>
> That isn't going to work, the current driver uses NAPI
> which means you need the rest of the 2.4.20-X networking
> bits too.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



[-] Steve Mickeler [ steve@neptune.ca ]

[|] Todays root password is brought to you by /dev/random

[+] 1024D/9AA80CDF = 4103 9E35 2713 D432 924F  3C2E A7B9 A0FE 9AA8 0CDF

Re: Linux 2.4.20-pre6 tg3 compile errors

[Jeff Garzik]

Steve Mickeler wrote:
> Ok, I applied the entire 2.4.20-pre6 and still get compile errors:
> 
> gcc -D__KERNEL__ -I/usr/src/test/linux-2.4.20-pre6/include -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
> -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686
> -nostdinc -iwithprefix include -DKBUILD_BASENAME=tg3  -c -o tg3.o tg3.c
> 
> tg3.c: In function `__tg3_set_rx_mode':
> tg3.c:4881: structure has no member named `vlgrp'


Wrap this line of code inside a

#if TG3_VLAN_TAG_USED
...line 4881 here...
#endif

Re: Linux 2.4.20-pre6 tg3 compile errors

[Steve Mickeler]

That seemed to have allowed a clean compile.

Heres the patch:

-----------------------------------------------------------------------------------------
diff -Naur linux-2.4.20-pre6/drivers/net/tg3.c linux-2.4.20-pre6-fixed/drivers/net/tg3.c
--- linux-2.4.20-pre6/drivers/net/tg3.c Tue Sep 10 21:53:24 2002
+++ linux-2.4.20-pre6-fixed/drivers/net/tg3.c   Tue Sep 10 21:44:53 2002
@@ -4878,8 +4878,10 @@

        rx_mode = tp->rx_mode & ~(RX_MODE_PROMISC |
                                  RX_MODE_KEEP_VLAN_TAG);
+#if TG3_VLAN_TAG_USED
        if (!tp->vlgrp)
                rx_mode |= RX_MODE_KEEP_VLAN_TAG;
+#endif

        if (dev->flags & IFF_PROMISC) {
                /* Promiscuous mode. */
-----------------------------------------------------------------------------------------



On Tue, 10 Sep 2002, Jeff Garzik wrote:

> Steve Mickeler wrote:
> > Ok, I applied the entire 2.4.20-pre6 and still get compile errors:
> >
> > gcc -D__KERNEL__ -I/usr/src/test/linux-2.4.20-pre6/include -Wall
> > -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
> > -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686
> > -nostdinc -iwithprefix include -DKBUILD_BASENAME=tg3  -c -o tg3.o tg3.c
> >
> > tg3.c: In function `__tg3_set_rx_mode':
> > tg3.c:4881: structure has no member named `vlgrp'
>
>
> Wrap this line of code inside a
>
> #if TG3_VLAN_TAG_USED
> ...line 4881 here...
> #endif
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



[-] Steve Mickeler [ steve@neptune.ca ]

[|] Todays root password is brought to you by /dev/random

[+] 1024D/9AA80CDF = 4103 9E35 2713 D432 924F  3C2E A7B9 A0FE 9AA8 0CDF

Re: Linux 2.4.20-pre6 tg3 compile errors

[David S. Miller]

   From: Steve Mickeler <steve@neptune.ca>
   Date: Tue, 10 Sep 2002 22:20:34 -0400 (EDT)
   
   gcc -D__KERNEL__ -I/usr/src/test/linux-2.4.20-pre6/include -Wall
   -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
   -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686
   -nostdinc -iwithprefix include -DKBUILD_BASENAME=tg3  -c -o tg3.o tg3.c
   
   tg3.c: In function `__tg3_set_rx_mode':
   tg3.c:4881: structure has no member named `vlgrp'
   make[3]: *** [tg3.o] Error 1
   make[3]: Leaving directory `/usr/src/test/linux-2.4.20-pre6/drivers/net'
   make[2]: *** [first_rule] Error 2
   make[2]: Leaving directory `/usr/src/test/linux-2.4.20-pre6/drivers/net'
   make[1]: *** [_subdir_net] Error 2
   make[1]: Leaving directory `/usr/src/test/linux-2.4.20-pre6/drivers'
   make: *** [_dir_drivers] Error 2

Sorry, I'll fix that.  Enable CONFIG_VLAN_8021Q as a workaround for
now.

Re: Linux 2.4.20-pre6 tg3 compile errors

[David S. Miller]

   From: Jeff Garzik <jgarzik@mandrakesoft.com>
   Date: Tue, 10 Sep 2002 22:37:25 -0400
   
   Wrap this line of code inside a
   
   #if TG3_VLAN_TAG_USED
   ...line 4881 here...
   #endif
   
Not sufficient, you need to have an "#else" clause that
sets RX_MODE_KEEP_VLAN_TAG all the time.

Re: Linux 2.4.20-pre6 tg3 compile errors

[Jeff Garzik]

David S. Miller wrote:
>    From: Jeff Garzik <jgarzik@mandrakesoft.com>
>    Date: Tue, 10 Sep 2002 22:37:25 -0400
>    
>    Wrap this line of code inside a
>    
>    #if TG3_VLAN_TAG_USED
>    ...line 4881 here...
>    #endif
>    
> Not sufficient, you need to have an "#else" clause that
> sets RX_MODE_KEEP_VLAN_TAG all the time.


So IOW what I said was correct, but Steve's patch was wrong :)

You don't need a #else clause because line 4882 sets 
RX_MODE_KEEP_VLAN_TAG unconditionally, if you #ifdef out line 4881.

	Jeff