* Re: [PATCH] n_tty.c buglet breaks error returns
@ 2002-09-23 3:45 Jeff Dike
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Dike @ 2002-09-23 3:45 UTC (permalink / raw)
To: marcelo; +Cc: linux-kernel
That was a bogus patch, sorry. 2.4.19 had the test right, my local pool
didn't. I had applied an earlier version of the patch, and didn't look
carefully enough at the rejects when I applied the 2.4.19 patch to it.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] n_tty.c buglet breaks error returns
@ 2002-09-21 17:58 Jeff Dike
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Dike @ 2002-09-21 17:58 UTC (permalink / raw)
To: marcelo; +Cc: linux-kernel, sapan
The tty SIGIO fix that went into 2.4.19 breaks error returns from the
underlying driver. Currently, any errors from the driver causes write_chan
to call schedule() rather than returning the error.
This broke the UML test suite, the fix below makes it work again.
Jeff
--- orig/drivers/char/n_tty.c Tue Sep 3 17:07:15 2002
+++ um/drivers/char/n_tty.c Sat Sep 21 13:22:32 2002
@@ -1180,7 +1180,7 @@
while (nr > 0) {
ssize_t num = opost_block(tty, b, nr);
if (num < 0){
- if(num != -EAGAIN)
+ if(num == -EAGAIN)
break;
retval = num;
goto break_out;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-09-23 2:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-23 3:45 [PATCH] n_tty.c buglet breaks error returns Jeff Dike
-- strict thread matches above, loose matches on Subject: below --
2002-09-21 17:58 Jeff Dike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®