* Re: [BK-2.5] [PATCH] bootmem crash fix
[not found] <200211222005.gAMK5t319194@hera.kernel.org>
@ 2002-11-22 21:12 ` David S. Miller
2002-11-22 21:24 ` William Lee Irwin III
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2002-11-22 21:12 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm
From: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date: Fri, 22 Nov 2002 19:31:53 +0000
From Roman Zippel. Don't assume that physical memory starts at
physical address zero.
Which would be a nice improvement, however:
- free_area_init_node(0, &contig_page_data, NULL, zones_size, 0, NULL);
+ free_area_init_node(0, &contig_page_data, NULL, zones_size,
+ __pa(PAGE_OFFSET) >> PAGE_SHIFT, NULL);
__pa(PAGE_OFFSET) is not necessarily the first physical address in
the system either.
I've never seen this even implied to be the case :-)
In any event, it isn't well defined and we should make it
so.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BK-2.5] [PATCH] bootmem crash fix
2002-11-22 21:12 ` [BK-2.5] [PATCH] bootmem crash fix David S. Miller
@ 2002-11-22 21:24 ` William Lee Irwin III
2002-11-22 21:26 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: William Lee Irwin III @ 2002-11-22 21:24 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-kernel, akpm
On Fri, Nov 22, 2002 at 01:12:59PM -0800, David S. Miller wrote:
> __pa(PAGE_OFFSET) is not necessarily the first physical address in
> the system either.
> I've never seen this even implied to be the case :-)
> In any event, it isn't well defined and we should make it
> so.
Would a first_pfn variable be in order?
Bill
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BK-2.5] [PATCH] bootmem crash fix
2002-11-22 21:24 ` William Lee Irwin III
@ 2002-11-22 21:26 ` David S. Miller
0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2002-11-22 21:26 UTC (permalink / raw)
To: wli; +Cc: linux-kernel, akpm
From: William Lee Irwin III <wli@holomorphy.com>
Date: Fri, 22 Nov 2002 13:24:19 -0800
Would a first_pfn variable be in order?
Just some silly "first_possible_paddr" macro would be fine.
It would even be fine, for now, to put it in mm.h and make it this
PAGE_OFFSET expression.
I just hate these expressions that "we know" mean something.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-11-22 21:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200211222005.gAMK5t319194@hera.kernel.org>
2002-11-22 21:12 ` [BK-2.5] [PATCH] bootmem crash fix David S. Miller
2002-11-22 21:24 ` William Lee Irwin III
2002-11-22 21:26 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®