swsusp: kill bogus wakeup warning

swsusp: kill bogus wakeup warning

[Pavel Machek]

Hi!

This kills 'bogus wakeup' warning from pdflush. Patch from Nigel,
please apply.
							Pavel

--- clean/mm/pdflush.c	2003-02-15 18:51:31.000000000 +0100
+++ linux/mm/pdflush.c	2003-02-21 10:41:33.000000000 +0100
@@ -103,9 +103,11 @@
 		my_work->when_i_went_to_sleep = jiffies;
 		spin_unlock_irq(&pdflush_lock);
 
-		if (current->flags & PF_FREEZE)
-			refrigerator(PF_IOTHREAD);
 		schedule();
+		if (current->flags & PF_FREEZE) {
+			refrigerator(PF_IOTHREAD);
+			continue;
+		}
 
 		spin_lock_irq(&pdflush_lock);
 		if (!list_empty(&my_work->list)) {

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

Re: swsusp and S3 fixes

[Linus Torvalds]

Pavel,
 your patch causes

	arch/i386/kernel/dmi_scan.c:482: warning: `reset_videobios_after_s3' defined but not used
	make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
	arch/i386/kernel/built-in.o: In function `reset_videomode_after_s3':
	arch/i386/kernel/built-in.o(.init.text+0x1e07): undefined reference to `acpi_video_flags'
	arch/i386/kernel/built-in.o: In function `reset_videobios_after_s3':
	arch/i386/kernel/built-in.o(.init.text+0x1e17): undefined reference to `acpi_video_flags'
	make: *** [.tmp_vmlinux1] Error 1

for me, with neither ACPI not SW_SUSPEND configured.

Don't call patches like this "trivial" if they haven't even been 
properly tested. 

			Linus

Re: swsusp and S3 fixes

[Pavel Machek]

Hi!

>  your patch causes
> 
> 	arch/i386/kernel/dmi_scan.c:482: warning: `reset_videobios_after_s3' defined but not used
> 	make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
> 	arch/i386/kernel/built-in.o: In function `reset_videomode_after_s3':
> 	arch/i386/kernel/built-in.o(.init.text+0x1e07): undefined reference to `acpi_video_flags'
> 	arch/i386/kernel/built-in.o: In function `reset_videobios_after_s3':
> 	arch/i386/kernel/built-in.o(.init.text+0x1e17): undefined reference to `acpi_video_flags'
> 	make: *** [.tmp_vmlinux1] Error 1
> 
> for me, with neither ACPI not SW_SUSPEND configured.
> 
> Don't call patches like this "trivial" if they haven't even been 
> properly tested. 

I wanted to mail you a fix but I see its already fixed in bk
tree. Sorry about that.
								Pavel
-- 
Horseback riding is like software...
...vgf orggre jura vgf serr.