* swsusp: kill bogus wakeup warning
@ 2003-02-21 9:48 Pavel Machek
2003-02-24 22:52 ` swsusp and S3 fixes Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2003-02-21 9:48 UTC (permalink / raw)
To: torvalds, kernel list, Rusty trivial patch monkey Russell, ncunningham
Hi!
This kills 'bogus wakeup' warning from pdflush. Patch from Nigel,
please apply.
Pavel
--- clean/mm/pdflush.c 2003-02-15 18:51:31.000000000 +0100
+++ linux/mm/pdflush.c 2003-02-21 10:41:33.000000000 +0100
@@ -103,9 +103,11 @@
my_work->when_i_went_to_sleep = jiffies;
spin_unlock_irq(&pdflush_lock);
- if (current->flags & PF_FREEZE)
- refrigerator(PF_IOTHREAD);
schedule();
+ if (current->flags & PF_FREEZE) {
+ refrigerator(PF_IOTHREAD);
+ continue;
+ }
spin_lock_irq(&pdflush_lock);
if (!list_empty(&my_work->list)) {
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: swsusp and S3 fixes
2003-02-21 9:48 swsusp: kill bogus wakeup warning Pavel Machek
@ 2003-02-24 22:52 ` Linus Torvalds
2003-02-24 23:11 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2003-02-24 22:52 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, Rusty trivial patch monkey Russell, ncunningham
Pavel,
your patch causes
arch/i386/kernel/dmi_scan.c:482: warning: `reset_videobios_after_s3' defined but not used
make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
arch/i386/kernel/built-in.o: In function `reset_videomode_after_s3':
arch/i386/kernel/built-in.o(.init.text+0x1e07): undefined reference to `acpi_video_flags'
arch/i386/kernel/built-in.o: In function `reset_videobios_after_s3':
arch/i386/kernel/built-in.o(.init.text+0x1e17): undefined reference to `acpi_video_flags'
make: *** [.tmp_vmlinux1] Error 1
for me, with neither ACPI not SW_SUSPEND configured.
Don't call patches like this "trivial" if they haven't even been
properly tested.
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: swsusp and S3 fixes
2003-02-24 22:52 ` swsusp and S3 fixes Linus Torvalds
@ 2003-02-24 23:11 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2003-02-24 23:11 UTC (permalink / raw)
To: Linus Torvalds; +Cc: kernel list
Hi!
> your patch causes
>
> arch/i386/kernel/dmi_scan.c:482: warning: `reset_videobios_after_s3' defined but not used
> make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
> arch/i386/kernel/built-in.o: In function `reset_videomode_after_s3':
> arch/i386/kernel/built-in.o(.init.text+0x1e07): undefined reference to `acpi_video_flags'
> arch/i386/kernel/built-in.o: In function `reset_videobios_after_s3':
> arch/i386/kernel/built-in.o(.init.text+0x1e17): undefined reference to `acpi_video_flags'
> make: *** [.tmp_vmlinux1] Error 1
>
> for me, with neither ACPI not SW_SUSPEND configured.
>
> Don't call patches like this "trivial" if they haven't even been
> properly tested.
I wanted to mail you a fix but I see its already fixed in bk
tree. Sorry about that.
Pavel
--
Horseback riding is like software...
...vgf orggre jura vgf serr.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-02-24 23:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-21 9:48 swsusp: kill bogus wakeup warning Pavel Machek
2003-02-24 22:52 ` swsusp and S3 fixes Linus Torvalds
2003-02-24 23:11 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®