* [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems
@ 2003-05-14 3:29 Christopher Hoover
2003-05-14 5:57 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Christopher Hoover @ 2003-05-14 3:29 UTC (permalink / raw)
To: linux-kernel, torvalds
Unless I'm missing something, there doesn't seem to be a good reason
for the block system to include SCSI ioctls unless there's a SCSI
block device (CONFIG_BLK_DEV_SD) in the system.
This is good for embedded systems with tight memory.
-ch
--
Christopher Hoover
mailto:ch(at)murgatroid.com
mailto:ch(at)hpl.hp.com
PATCH FOLLOWS
KernelVersion: 2.5.68
diff -Naur -X dontdiff.txt linux-2.5.68-rmk1/drivers/block/Makefile linux-2.5.68-rmk1-ceiva1/drivers/block/Makefile
--- linux-2.5.68-rmk1/drivers/block/Makefile 2003-05-06 11:53:42.000000000 -0700
+++ linux-2.5.68-rmk1-ceiva1/drivers/block/Makefile 2003-05-13 19:58:38.000000000 -0700
@@ -8,8 +8,9 @@
# In the future, some of these should be built conditionally.
#
-obj-y := elevator.o ll_rw_blk.o ioctl.o genhd.o scsi_ioctl.o deadline-iosched.o
+obj-y := elevator.o ll_rw_blk.o ioctl.o genhd.o deadline-iosched.o
+obj-$(CONFIG_BLK_DEV_SD) += scsi_ioctl.o
obj-$(CONFIG_MAC_FLOPPY) += swim3.o
obj-$(CONFIG_BLK_DEV_FD) += floppy.o
obj-$(CONFIG_BLK_DEV_FD98) += floppy98.o
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems
2003-05-14 3:29 [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems Christopher Hoover
@ 2003-05-14 5:57 ` Christoph Hellwig
2003-05-14 6:05 ` Christopher Hoover
2003-05-14 8:08 ` Christopher Hoover
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2003-05-14 5:57 UTC (permalink / raw)
To: Christopher Hoover; +Cc: linux-kernel, torvalds
On Tue, May 13, 2003 at 08:29:20PM -0700, Christopher Hoover wrote:
> Unless I'm missing something, there doesn't seem to be a good reason
> for the block system to include SCSI ioctls unless there's a SCSI
> block device (CONFIG_BLK_DEV_SD) in the system.
That's broken. You can use them on ide, sd and sr currently.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems
2003-05-14 5:57 ` Christoph Hellwig
@ 2003-05-14 6:05 ` Christopher Hoover
2003-05-14 8:08 ` Christopher Hoover
1 sibling, 0 replies; 6+ messages in thread
From: Christopher Hoover @ 2003-05-14 6:05 UTC (permalink / raw)
To: 'Christoph Hellwig'; +Cc: linux-kernel, torvalds
> > Unless I'm missing something, there doesn't seem to be a good reason
> > for the block system to include SCSI ioctls unless there's a SCSI
> > block device (CONFIG_BLK_DEV_SD) in the system.
>
> That's broken. You can use them on ide, sd and sr currently.
Thanks for the G-2. I'll revise the patch ...
-ch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems
2003-05-14 5:57 ` Christoph Hellwig
2003-05-14 6:05 ` Christopher Hoover
@ 2003-05-14 8:08 ` Christopher Hoover
2003-05-14 8:10 ` Christoph Hellwig
2003-05-14 8:12 ` Jens Axboe
1 sibling, 2 replies; 6+ messages in thread
From: Christopher Hoover @ 2003-05-14 8:08 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel, torvalds, ch
On Wed, May 14, 2003 at 06:57:52AM +0100, Christoph Hellwig wrote:
> On Tue, May 13, 2003 at 08:29:20PM -0700, Christopher Hoover wrote:
> > Unless I'm missing something, there doesn't seem to be a good reason
> > for the block system to include SCSI ioctls unless there's a SCSI
> > block device (CONFIG_BLK_DEV_SD) in the system.
>
> That's broken. You can use them on ide, sd and sr currently.
OK, let's try that again.
diff -X /home/ch/src/dontdiff.txt -Naurp linux-2.5.69.orig/drivers/block/Kconfig linux-2.5.69/drivers/block/Kconfig
--- linux-2.5.69.orig/drivers/block/Kconfig 2003-05-04 16:53:08.000000000 -0700
+++ linux-2.5.69/drivers/block/Kconfig 2003-05-14 00:58:36.000000000 -0700
@@ -348,3 +348,6 @@ config LBD
endmenu
+config SCSI_IOCTL
+ bool
+ default y if IDE||SCSI
diff -X /home/ch/src/dontdiff.txt -Naurp linux-2.5.69.orig/drivers/block/Makefile linux-2.5.69/drivers/block/Makefile
--- linux-2.5.69.orig/drivers/block/Makefile 2003-05-04 16:53:37.000000000 -0700
+++ linux-2.5.69/drivers/block/Makefile 2003-05-14 00:58:50.000000000 -0700
@@ -8,7 +8,9 @@
# In the future, some of these should be built conditionally.
#
-obj-y := elevator.o ll_rw_blk.o ioctl.o genhd.o scsi_ioctl.o deadline-iosched.o
+obj-y := elevator.o ll_rw_blk.o ioctl.o genhd.o deadline-iosched.o
+
+obj-$(CONFIG_SCSI_IOCTL) += scsi_ioctl.o
obj-$(CONFIG_MAC_FLOPPY) += swim3.o
obj-$(CONFIG_BLK_DEV_FD) += floppy.o
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems
2003-05-14 8:08 ` Christopher Hoover
@ 2003-05-14 8:10 ` Christoph Hellwig
2003-05-14 8:12 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2003-05-14 8:10 UTC (permalink / raw)
To: Christopher Hoover; +Cc: Christoph Hellwig, linux-kernel, torvalds
On Wed, May 14, 2003 at 01:08:02AM -0700, Christopher Hoover wrote:
> On Wed, May 14, 2003 at 06:57:52AM +0100, Christoph Hellwig wrote:
> > On Tue, May 13, 2003 at 08:29:20PM -0700, Christopher Hoover wrote:
> > > Unless I'm missing something, there doesn't seem to be a good reason
> > > for the block system to include SCSI ioctls unless there's a SCSI
> > > block device (CONFIG_BLK_DEV_SD) in the system.
> >
> > That's broken. You can use them on ide, sd and sr currently.
>
> OK, let's try that again.
Well, the idea of this code is that it is generic - I'd rather make it
a standalone config option and add stubs so driver still compile with it disabled.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems
2003-05-14 8:08 ` Christopher Hoover
2003-05-14 8:10 ` Christoph Hellwig
@ 2003-05-14 8:12 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2003-05-14 8:12 UTC (permalink / raw)
To: Christopher Hoover; +Cc: Christoph Hellwig, linux-kernel, torvalds
On Wed, May 14 2003, Christopher Hoover wrote:
> On Wed, May 14, 2003 at 06:57:52AM +0100, Christoph Hellwig wrote:
> > On Tue, May 13, 2003 at 08:29:20PM -0700, Christopher Hoover wrote:
> > > Unless I'm missing something, there doesn't seem to be a good reason
> > > for the block system to include SCSI ioctls unless there's a SCSI
> > > block device (CONFIG_BLK_DEV_SD) in the system.
> >
> > That's broken. You can use them on ide, sd and sr currently.
>
> OK, let's try that again.
That's better, but block/scsi_ioctl.c is potentially useful on non ide
or scsi systems too.
I agree with the config option, though.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-05-14 8:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-14 3:29 [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems Christopher Hoover
2003-05-14 5:57 ` Christoph Hellwig
2003-05-14 6:05 ` Christopher Hoover
2003-05-14 8:08 ` Christopher Hoover
2003-05-14 8:10 ` Christoph Hellwig
2003-05-14 8:12 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®