Machin dependent serial port patches

Machin dependent serial port patches

[J.C. Wren]

	One of the things I noticed in the port of 2.5.69 to the 386EX embedded 
system is that serial.h appears to not be a mach-xxx positionable file.  The 
386EX board uses standard 8250 type serial ports, but at 3.6864Mhz instad of 
1.8432Mhz.  There appears to be no way to build a patch set without modifying 
include/i386/serial.h.  Would this not be better places in mach-defaults?  
I'm trying very hard to modify as few files as possible when building these 
patch sets.

	--John

Re: Machin dependent serial port patches

[Alan Cox]

On Maw, 2003-05-20 at 01:56, J.C. Wren wrote:
> 	One of the things I noticed in the port of 2.5.69 to the 386EX embedded 
> system is that serial.h appears to not be a mach-xxx positionable file.  The 
> 386EX board uses standard 8250 type serial ports, but at 3.6864Mhz instad of 
> 1.8432Mhz.  There appears to be no way to build a patch set without modifying 
> include/i386/serial.h.  Would this not be better places in mach-defaults?  
> I'm trying very hard to modify as few files as possible when building these 
> patch sets.

Making asm-i386/serial.h include a mach- file sounds the right thing to
do. mach- for x86 is pretty new so a lot of stuff that maybe should be
in it, hasnt migrated yet.

The counter argument however is that you should be able to use setserial
to adjust the baud base so you dont need to change anything 8)

Re: Machin dependent serial port patches

[J.C. Wren]

	The only prolem with using setserial is my console is one one of these serial 
port (headless system.  I failed to mention that earlier).  So everything 
that comes out the console at the wrong rate :(  However, Milton D. Miller 
suggested looking at early_serial_rgister, which is used on ppc and ia64.  
That might help.

	--John

On Tuesday 20 May 2003 08:09 am, Alan Cox wrote:
> On Maw, 2003-05-20 at 01:56, J.C. Wren wrote:
> > 	One of the things I noticed in the port of 2.5.69 to the 386EX embedded
> > system is that serial.h appears to not be a mach-xxx positionable file. 
> > The 386EX board uses standard 8250 type serial ports, but at 3.6864Mhz
> > instad of 1.8432Mhz.  There appears to be no way to build a patch set
> > without modifying include/i386/serial.h.  Would this not be better places
> > in mach-defaults? I'm trying very hard to modify as few files as possible
> > when building these patch sets.
>
> Making asm-i386/serial.h include a mach- file sounds the right thing to
> do. mach- for x86 is pretty new so a lot of stuff that maybe should be
> in it, hasnt migrated yet.
>
> The counter argument however is that you should be able to use setserial
> to adjust the baud base so you dont need to change anything 8)
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: Machin dependent serial port patches

[David Woodhouse]

On Tue, 2003-05-20 at 13:09, Alan Cox wrote:
> On Maw, 2003-05-20 at 01:56, J.C. Wren wrote:
> > 	One of the things I noticed in the port of 2.5.69 to the 386EX embedded 
> > system is that serial.h appears to not be a mach-xxx positionable file.  The 
> > 386EX board uses standard 8250 type serial ports, but at 3.6864Mhz instad of 
> > 1.8432Mhz.  There appears to be no way to build a patch set without modifying 
> > include/i386/serial.h.  Would this not be better places in mach-defaults?  
> > I'm trying very hard to modify as few files as possible when building these 
> > patch sets.
> 
> Making asm-i386/serial.h include a mach- file sounds the right thing to
> do. mach- for x86 is pretty new so a lot of stuff that maybe should be
> in it, hasnt migrated yet.

I disagree. I think it would be better to get rid of the hard-coded
table altogether and let something in the machine-specific code call
register_serial() during early boot.

Even on PeeCee hardware, that lets us do the superio chip probe and
potentially register high-speed serial ports, before the pnpbios probe
and finally falling back to the old standard I/O addresses.

-- 
dwmw2