From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Steven Cole <elenstev@mesatop.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: [Patch] 2.5.70-bk11 zlib merge #4 pure magic
Date: Fri, 6 Jun 2003 22:13:07 +0200 [thread overview]
Message-ID: <20030606201306.GJ10487@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20030606200051.GI10487@wohnheim.fh-wedel.de>
Hi Linus!
This one is pure magic, really. No comment and inspection of the code
doesn't show much either. But judging from the other changes, this
should also fix a real problem, at least a theoretical one.
The only code that could be bitten by this change is ppp, so I changed
that as well. Paulus, could you have a quick look at it?
Jörn
--
This above all: to thine own self be true.
-- Shakespeare
--- linux-2.5.70-bk11/lib/zlib_deflate/deflate.c~zlib_merge_magic 2003-06-06 20:44:51.000000000 +0200
+++ linux-2.5.70-bk11/lib/zlib_deflate/deflate.c 2003-06-06 22:05:30.000000000 +0200
@@ -216,7 +216,7 @@
windowBits = -windowBits;
}
if (memLevel < 1 || memLevel > MAX_MEM_LEVEL || method != Z_DEFLATED ||
- windowBits < 8 || windowBits > 15 || level < 0 || level > 9 ||
+ windowBits < 9 || windowBits > 15 || level < 0 || level > 9 ||
strategy < 0 || strategy > Z_HUFFMAN_ONLY) {
return Z_STREAM_ERROR;
}
--- linux-2.5.70-bk11/include/linux/ppp-comp.h~zlib_merge_magic 2003-06-05 17:46:35.000000000 +0200
+++ linux-2.5.70-bk11/include/linux/ppp-comp.h 2003-06-06 22:07:08.000000000 +0200
@@ -182,7 +182,7 @@
#define CI_DEFLATE_DRAFT 24 /* value used in original draft RFC */
#define CILEN_DEFLATE 4 /* length of its config option */
-#define DEFLATE_MIN_SIZE 8
+#define DEFLATE_MIN_SIZE 9
#define DEFLATE_MAX_SIZE 15
#define DEFLATE_METHOD_VAL 8
#define DEFLATE_SIZE(x) (((x) >> 4) + DEFLATE_MIN_SIZE)
next prev parent reply other threads:[~2003-06-06 19:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-06 18:31 [Patch] 2.5.70-bk11 zlib cleanup #1 local Jörn Engel
2003-06-06 18:32 ` [Patch] 2.5.70-bk11 zlib cleanup #2 cpp Jörn Engel
2003-06-06 18:39 ` [Patch] 2.5.70-bk11 zlib cleanup #3 Z_NULL Jörn Engel
2003-06-06 18:52 ` [Patch] 2.5.70-bk11 zlib cleanup #4 casts Jörn Engel
2003-06-06 19:23 ` [Patch] 2.5.70-bk11 zlib merge #1 turboc Jörn Engel
2003-06-06 19:28 ` [Patch] 2.5.70-bk11 zlib merge #2 return code Jörn Engel
2003-06-06 20:00 ` [Patch] 2.5.70-bk11 zlib merge #3 inffast.c Jörn Engel
2003-06-06 20:13 ` Jörn Engel [this message]
2003-06-06 20:36 ` [Patch] 2.5.70-bk11 zlib merge #4 pure magic Bartlomiej Zolnierkiewicz
2003-06-06 21:38 ` Is there a bug with su, and /dev/std*? J.C. Wren
2003-06-07 9:20 ` [Patch] 2.5.70-bk11 zlib merge #4 pure magic Jörn Engel
2003-06-07 9:40 ` Paul Mackerras
2003-06-07 10:02 ` Jörn Engel
2003-06-07 11:42 ` Paul Mackerras
2003-06-06 18:54 ` [Patch] 2.5.70-bk11 zlib cleanup #3 Z_NULL Linus Torvalds
2003-06-06 19:13 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030606201306.GJ10487@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=elenstev@mesatop.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®