* [2.5 patch] yam.c: return IRQ_NONE in error case
@ 2003-06-20 0:01 Adrian Bunk
2003-06-20 4:34 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2003-06-20 0:01 UTC (permalink / raw)
To: frible; +Cc: linux-kernel, linux-net, trivial
Please check whether the following patch to return IRQ_NONE in case of
errors is correct:
--- linux-2.5.72-mm2/drivers/net/hamradio/yam.c.old 2003-06-20 01:57:02.000000000 +0200
+++ linux-2.5.72-mm2/drivers/net/hamradio/yam.c 2003-06-20 01:57:41.000000000 +0200
@@ -742,7 +742,7 @@
if (--counter <= 0) {
printk(KERN_ERR "%s: too many irq iir=%d\n", dev->name, iir);
- return;
+ return IRQ_NONE;
}
if (msr & TX_RDY) {
++yp->nb_mdint;
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [2.5 patch] yam.c: return IRQ_NONE in error case
2003-06-20 0:01 [2.5 patch] yam.c: return IRQ_NONE in error case Adrian Bunk
@ 2003-06-20 4:34 ` Rusty Russell
2003-06-21 23:36 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2003-06-20 4:34 UTC (permalink / raw)
To: Adrian Bunk; +Cc: frible, linux-kernel, linux-net, alan, jgarzik
In message <20030620000137.GG29247@fs.tum.de> you write:
> Please check whether the following patch to return IRQ_NONE in case of
> errors is correct:
>
> --- linux-2.5.72-mm2/drivers/net/hamradio/yam.c.old 2003-06-20 01:57:02.000000000 +0200
> +++ linux-2.5.72-mm2/drivers/net/hamradio/yam.c 2003-06-20 01:57:41.000000000 +0200
> @@ -742,7 +742,7 @@
>
> if (--counter <= 0) {
> printk(KERN_ERR "%s: too many irq iir=%d\n", dev->name, iir);
> - return;
> + return IRQ_NONE;
> }
IRQ_HANDLED, I think: it did handle them, but decided it was
livelocked and exited.
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [2.5 patch] yam.c: return IRQ_NONE in error case
2003-06-20 4:34 ` Rusty Russell
@ 2003-06-21 23:36 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2003-06-21 23:36 UTC (permalink / raw)
To: Rusty Russell; +Cc: frible, linux-kernel, linux-net, alan, jgarzik
On Fri, Jun 20, 2003 at 02:34:42PM +1000, Rusty Russell wrote:
> In message <20030620000137.GG29247@fs.tum.de> you write:
> > Please check whether the following patch to return IRQ_NONE in case of
> > errors is correct:
> >
> > --- linux-2.5.72-mm2/drivers/net/hamradio/yam.c.old 2003-06-20 01:57:02.000000000 +0200
> > +++ linux-2.5.72-mm2/drivers/net/hamradio/yam.c 2003-06-20 01:57:41.000000000 +0200
> > @@ -742,7 +742,7 @@
> >
> > if (--counter <= 0) {
> > printk(KERN_ERR "%s: too many irq iir=%d\n", dev->name, iir);
> > - return;
> > + return IRQ_NONE;
> > }
>
> IRQ_HANDLED, I think: it did handle them, but decided it was
> livelocked and exited.
akpm already sent a better fix to Linus.
> Cheers,
> Rusty.
Thanks
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-06-21 23:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-20 0:01 [2.5 patch] yam.c: return IRQ_NONE in error case Adrian Bunk
2003-06-20 4:34 ` Rusty Russell
2003-06-21 23:36 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®