mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: eyal@eyal.emu.id.au, linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test7: saa7134 breaks on gcc 2.95
Date: Tue, 14 Oct 2003 22:34:25 -0700	[thread overview]
Message-ID: <20031014223425.6ee72e10.akpm@osdl.org> (raw)
In-Reply-To: <200310150716.58737.ioe-lkml@rameria.de>

Ingo Oeser <ioe-lkml@rameria.de> wrote:
>
> GCC 2.95 doesn't like no space BEFORE AND AFTER the comma in the argument right
>  before the "## arg".

Yup.

--- 25/drivers/media/video/saa7134/saa7134-core.c~a	Tue Oct 14 22:29:09 2003
+++ 25-akpm/drivers/media/video/saa7134/saa7134-core.c	Tue Oct 14 22:29:25 2003
@@ -95,7 +95,7 @@ struct list_head  saa7134_devlist;
 unsigned int      saa7134_devcount;
 
 #define dprintk(fmt, arg...)	if (core_debug) \
-	printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
+	printk(KERN_DEBUG "%s/core: " fmt, dev->name , ## arg)
 
 /* ------------------------------------------------------------------ */
 /* debug help functions                                               */

_


      reply	other threads:[~2003-10-15  5:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-15  0:38 Eyal Lebedinsky
2003-10-15  0:59 ` Andrew Morton
2003-10-15  5:16   ` Ingo Oeser
2003-10-15  5:34     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031014223425.6ee72e10.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=eyal@eyal.emu.id.au \
    --cc=ioe-lkml@rameria.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®