From: Ingo Oeser <ioe-lkml@rameria.de>
To: Andrew Morton <akpm@osdl.org>, Eyal Lebedinsky <eyal@eyal.emu.id.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test7: saa7134 breaks on gcc 2.95
Date: Wed, 15 Oct 2003 07:16:58 +0200 [thread overview]
Message-ID: <200310150716.58737.ioe-lkml@rameria.de> (raw)
In-Reply-To: <20031014175938.04d94087.akpm@osdl.org>
On Wednesday 15 October 2003 02:59, Andrew Morton wrote:
> Eyal Lebedinsky <eyal@eyal.emu.id.au> wrote:
> > This compiler does not like dangling comma in funcs, so this patch
> > is needed. For:
> >
> > #define dprintk(fmt, arg...) if (core_debug) \
> > printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
> >
> > Lines like this:
> >
> > dprintk("hwinit1\n");
> >
> > should be hacked like this:
> >
> > dprintk("hwinit1\n", "");
>
> I couldn't find a sane way. Ended up doing this:
[splitting the printk]
GCC 2.95 doesn't like no space BEFORE AND AFTER the comma in the argument right
before the "## arg".
So just having a space there should work without splitting the printk. Not
compile tested, since I need to go now.
Regards
Ingo Oeser
next prev parent reply other threads:[~2003-10-15 5:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-15 0:38 Eyal Lebedinsky
2003-10-15 0:59 ` Andrew Morton
2003-10-15 5:16 ` Ingo Oeser [this message]
2003-10-15 5:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310150716.58737.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=akpm@osdl.org \
--cc=eyal@eyal.emu.id.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®