From: Eyal Lebedinsky <eyal@eyal.emu.id.au>
To: list linux-kernel <linux-kernel@vger.kernel.org>
Subject: 2.6.0-test7: saa7134 breaks on gcc 2.95
Date: Wed, 15 Oct 2003 10:38:29 +1000 [thread overview]
Message-ID: <3F8C9705.26CA0B63@eyal.emu.id.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
This compiler does not like dangling comma in funcs, so this patch
is needed. For:
#define dprintk(fmt, arg...) if (core_debug) \
printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
Lines like this:
dprintk("hwinit1\n");
should be hacked like this:
dprintk("hwinit1\n", "");
Or maybe someone knows a better solution.
--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
[-- Attachment #2: 2.6.0-test7.saa7134-core.patch --]
[-- Type: text/plain, Size: 821 bytes --]
--- linux/drivers/media/video/saa7134/saa7134-core.c.orig Wed Oct 15 10:30:44 2003
+++ linux/drivers/media/video/saa7134/saa7134-core.c Wed Oct 15 10:31:10 2003
@@ -624,7 +624,7 @@
/* early init (no i2c, no irq) */
static int saa7134_hwinit1(struct saa7134_dev *dev)
{
- dprintk("hwinit1\n");
+ dprintk("hwinit1\n", "");
saa_writel(SAA7134_IRQ1, 0);
saa_writel(SAA7134_IRQ2, 0);
@@ -675,7 +675,7 @@
/* late init (with i2c + irq) */
static int saa7134_hwinit2(struct saa7134_dev *dev)
{
- dprintk("hwinit2\n");
+ dprintk("hwinit2\n", "");
saa7134_video_init2(dev);
saa7134_tvaudio_init2(dev);
@@ -703,7 +703,7 @@
/* shutdown */
static int saa7134_hwfini(struct saa7134_dev *dev)
{
- dprintk("hwfini\n");
+ dprintk("hwfini\n", "");
switch (dev->pci->device) {
case PCI_DEVICE_ID_PHILIPS_SAA7134:
next reply other threads:[~2003-10-15 0:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-15 0:38 Eyal Lebedinsky [this message]
2003-10-15 0:59 ` Andrew Morton
2003-10-15 5:16 ` Ingo Oeser
2003-10-15 5:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8C9705.26CA0B63@eyal.emu.id.au \
--to=eyal@eyal.emu.id.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®