Re: [patch] ide.c as a module

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

On Thursday 11 of December 2003 22:25, Bartlomiej Zolnierkiewicz wrote:
> > --- linux-2.4.23.org/drivers/ide/ide.c  2003-11-28 19:26:20.000000000
> > +0100 +++ linux-2.4.23/drivers/ide/ide.c      2004-03-11
> > 20:31:51.000000000 +0100 @@ -514,11 +514,7 @@
> >
> >  void ide_probe_module (int revaldiate)
> >  {
> > -       if (!ide_probe) {
> > -#if  defined(CONFIG_BLK_DEV_IDE_MODULE)
> > -               (void) request_module("ide-probe-mod");
> > -#endif
> > -       } else {
> > +       if (ide_probe) {
> >                 (void) ide_probe->init();
> >         }
> >         revalidate_drives(revaldiate);
>
> You should make this change in ide_register_hw() instead:
>
> -		ide_probe_module();
> +#ifdef MODULE
> +		if (ideprobe_init_module() == -EBUSY)
> +#endif
> +			ideprobe_init();
>
> And get rid of ide_probe pointer.

and of course of ide_probe_module().