Re: [patch] ide.c as a module

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

On Friday 12 of December 2003 15:42, Daniel Tram Lux wrote:
> Hi,
>
> I tried with using only your suggested changes and removing the ide_probe
                            ^^^^
Your patch + changes or only changes?

> ptr, but due to (in include/asm-i386/ide.h) where CONFIG_BLK_DEV_IDEPCI is
> indeed undefined:
>
> static __inline__ void ide_init_default_hwifs(void)
> {
> #ifndef CONFIG_BLK_DEV_IDEPCI
> 	hw_regs_t hw;
> 	int index;
>
> 	for(index = 0; index < MAX_HWIFS; index++) {
> 		memset(&hw, 0, sizeof hw);
> 		ide_init_hwif_ports(&hw, ide_default_io_base(index), 0, NULL);
> 		hw.irq = ide_default_irq(ide_default_io_base(index));
> 		ide_register_hw(&hw, NULL);
> 	}
> #endif /* CONFIG_BLK_DEV_IDEPCI */
> }
>
> I get the following probing messages (I enabled a debug message which is
> why there are so many messages):

"initializing = 1" must be moved from ide_init() to ide_init_data()
(just before ide_init_default_hwifs() call).

--bart