mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: linux@horizon.com
To: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: GCC 3.4 Heads-up
Date: 26 Dec 2003 11:02:06 -0000	[thread overview]
Message-ID: <20031226110206.28382.qmail@science.horizon.com> (raw)

> Similarly, what the _hell_ does the gcc extension
> 
> 	int a;
> 
> 	(char)a += b;
> 
> really mean? The whole extension is just braindamaged,

It means a = (int)((char)a + b).
(Modulo the fact that the value of the expression is the sum of type
char and not the final value of type int.)

Applied to integer types, it *is* pretty brain damaged.  But applied to
pointer types, it makes a lot more sense.

This is because "a += b" in C is actually "a += b * sizeof(*a)", and
sometimes you want a different *a.

In particular, 1 is a popular value.

Consider the common case of a structure which has a bunch of variable-sized
blocks with a standard header:

struct foo {
	unsigned type, size;
	...
} a;

Then you *do* have to write
	a = (struct foo *)((char *)a + a->size);

and I might argue that

	(char *)a += a->size;

is definitely cleaner.

Or consider the case when the structure doesn't have an explicit size
and you have a big case statement for parsing it:

switch (a->type) {
	case BAR:
		process_bar_chunk(((struct bar *)a)++);
		break;
	case BAZ:
		process_baz_chunk(((struct baz *)a)++);
		break;
	...
};

Isn't that code a bit nicer looking?  I put the redundant parens
in to remind people that I didn't mean to write "(struct bar *)(a++)"
(which also has its legitimate uses).


Necessary, no.  But not "brain damaged", either.
It's well-defined and has legitimate uses.

             reply	other threads:[~2003-12-26 11:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-26 11:02 linux [this message]
2003-12-26 20:05 ` Linus Torvalds
2003-12-27 16:39 ` Andreas Schwab
     [not found] <16PqK-8eK-1@gated-at.bofh.it>
     [not found] ` <16RiU-2kO-1@gated-at.bofh.it>
     [not found]   ` <16S5h-3no-5@gated-at.bofh.it>
2004-01-06 21:06     ` David Mosberger-Tang
2004-01-06 22:33       ` Richard Henderson
2004-01-06 23:23         ` Linus Torvalds
2004-01-07  9:54           ` Richard Henderson
  -- strict thread matches above, loose matches on Subject: below --
2003-12-26  1:46 Chris Meadors
2003-12-26  3:46 ` H. Peter Anvin
2003-12-26  4:34   ` Linus Torvalds
2003-12-26  6:04     ` H. Peter Anvin
2003-12-26  6:58     ` Andy Isaacson
2003-12-26  7:07       ` H. Peter Anvin
2003-12-26  7:08       ` Linus Torvalds
2003-12-29 16:13       ` David Lloyd
2004-01-02 21:57     ` Bill Davidsen
2004-01-03 21:11       ` Krzysztof Halasa
2004-01-04  5:48         ` Bill Davidsen
2004-01-04 20:41           ` Linus Torvalds
2004-01-05  1:28             ` Bill Davidsen
2004-01-05  1:38               ` Måns Rullgård
2004-01-05 23:49                 ` Ingo Oeser
2004-01-05  2:25               ` Linus Torvalds
2004-01-05  4:15                 ` Bill Davidsen
2004-01-05  4:36                   ` Linus Torvalds
2003-12-30  1:37 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031226110206.28382.qmail@science.horizon.com \
    --to=linux@horizon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®