mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bill Davidsen <davidsen@tmr.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: GCC 3.4 Heads-up
Date: Sun, 04 Jan 2004 00:48:00 -0500	[thread overview]
Message-ID: <3FF7A910.40703@tmr.com> (raw)
In-Reply-To: <m365fsu48n.fsf@defiant.pm.waw.pl>

Krzysztof Halasa wrote:
> Bill Davidsen <davidsen@tmr.com> writes:
> 
> 
>>I would probably write
>>   ( a ? b : c ) = d;
>>instead, having learned C when some compilers parsed ? wrong without
>>parens. Actually I can't imagine writing that at all, but at least
>>with parens humans can read it easily. Ugly code.
>>
>>Your suggestion is not portable, if b or c are declared "register"
>>there are compilers which will not allow taking the address, and gcc
>>will give you a warning.
> 
> 
> One can write as well:
> 
> if (a)
>         b = d;
> else
>         c = d;
> 
> Might be more readable and it is what the compiler does.

Since that's a matter of taste I can't disagree. The point was that the 
original post used
   *(a ? &b : &c) = d;
which generates either warnings or errors if b or c is a register 
variable, because you are not allowed to take the address of a register. 
It seems gcc does it anyway by intuiting what you mean, but it's not 
portable in the sense of being error-free code.

It was a nit, I didn't mean to start a controversy, although if "d" is 
actually a complex expression it is certainly less typing as I showed 
it, and prevents a future maintainer from changing one RHS and not the 
other. That's defensive programming.


-- 
bill davidsen <davidsen@tmr.com>
   CTO TMR Associates, Inc
   Doing interesting things with small computers since 1979

  reply	other threads:[~2004-01-04  5:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-26  1:46 Chris Meadors
2003-12-26  3:46 ` H. Peter Anvin
2003-12-26  4:34   ` Linus Torvalds
2003-12-26  6:04     ` H. Peter Anvin
2003-12-26  6:58     ` Andy Isaacson
2003-12-26  7:07       ` H. Peter Anvin
2003-12-26  7:08       ` Linus Torvalds
2003-12-29 16:13       ` David Lloyd
2004-01-02 21:57     ` Bill Davidsen
2004-01-03 21:11       ` Krzysztof Halasa
2004-01-04  5:48         ` Bill Davidsen [this message]
2004-01-04 20:41           ` Linus Torvalds
2004-01-05  1:28             ` Bill Davidsen
2004-01-05  1:38               ` Måns Rullgård
2004-01-05 23:49                 ` Ingo Oeser
2004-01-05  2:25               ` Linus Torvalds
2004-01-05  4:15                 ` Bill Davidsen
2004-01-05  4:36                   ` Linus Torvalds
2003-12-30  1:37 ` Rusty Russell
2003-12-26 11:02 linux
2003-12-26 20:05 ` Linus Torvalds
2003-12-27 16:39 ` Andreas Schwab
     [not found] <16PqK-8eK-1@gated-at.bofh.it>
     [not found] ` <16RiU-2kO-1@gated-at.bofh.it>
     [not found]   ` <16S5h-3no-5@gated-at.bofh.it>
2004-01-06 21:06     ` David Mosberger-Tang
2004-01-06 22:33       ` Richard Henderson
2004-01-06 23:23         ` Linus Torvalds
2004-01-07  9:54           ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FF7A910.40703@tmr.com \
    --to=davidsen@tmr.com \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome