From: Andi Kleen <ak@colin2.muc.de>
To: Linus Torvalds <torvalds@osdl.org>, Andi Kleen <ak@muc.de>,
Andrew Morton <akpm@osdl.org>,
jh@suse.cz, Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add noinline attribute
Date: 18 Jan 2004 21:58:00 +0100 [thread overview]
Date: Sun, 18 Jan 2004 21:58:00 +0100 [thread overview]
Message-ID: <20040118205800.GA68521@colin2.muc.de> (raw)
In-Reply-To: <20040118204700.GA31601@twiddle.net>
On Sun, Jan 18, 2004 at 12:47:00PM -0800, Richard Henderson wrote:
> On Fri, Jan 16, 2004 at 11:13:45AM +0100, Andi Kleen wrote:
> > Ok, here is a new patch that does the whole thing in generic code and for
> > modules too. I didn't bother to change the sort algorithm because the
> > existing one works well enough.
>
> One, you've still got the function marked __init.
Already fixed.
>
> Two, the format of struct exception_table_entry is arch specific.
> That comparison won't work on Alpha, because "insn" is encoded
> pc-relative.
Hmpf. Would an extable_compare() function in an asm-*/ file work ?
-Andi
next prev parent reply other threads:[~2004-01-18 20:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 8:31 Andi Kleen
2004-01-14 23:23 ` Linus Torvalds
2004-01-15 7:48 ` Andi Kleen
2004-01-15 22:55 ` Linus Torvalds
2004-01-16 0:26 ` Peter Osterlund
2004-01-16 10:13 ` Andi Kleen
2004-01-18 20:47 ` Richard Henderson
2004-01-18 20:58 ` Andi Kleen [this message]
2004-01-19 0:41 ` Richard Henderson
2004-01-18 23:07 ` [PATCH] Add noinline attribute - new extable sort patch Andi Kleen
2004-01-19 0:52 ` Richard Henderson
2004-01-19 1:01 ` Andi Kleen
2004-01-19 11:26 ` Rusty Russell
2004-01-15 0:35 ` [PATCH] Add noinline attribute Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040118205800.GA68521@colin2.muc.de \
--to=ak@colin2.muc.de \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=jh@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®