mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Andi Kleen <ak@colin2.muc.de>
Cc: Andi Kleen <ak@muc.de>, Andrew Morton <akpm@osdl.org>,
	jh@suse.cz, Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add noinline attribute
Date: Thu, 15 Jan 2004 14:55:19 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0401151448200.2597@evo.osdl.org> (raw)
In-Reply-To: <20040115074834.GA38796@colin2.muc.de>



On Wed, 15 Jan 2004, Andi Kleen wrote:
> 
> Actually you would get a non booting system because the broken mount
> ABI does a stress test of EFAULT on every boot.

There is somethinglike _three_ exceptions that get any kind of testing: 
the WP bit, the mount interface, and the FP fault check. 

That's three out of several thousand, so coverage really sucks. That's why 
I'd rather just sort the damn thing once and for all, and not have that 
issue pop up every once in a while.

> That's fine for me. In fact I did this some time ago on x86-64 when I 
> ran into similar problems. Here's a port of the x86-64 sort function.

Ugh. Can't we just make this be generic code (and that means calling it in
the module loading code too..)?

As to bubble sort (which is fine for something that is 99% sorted anyway),
isn't it better to continue pushing the entry down when you find something 
out of order? That way you don't have to repeat the whole scan, you just 
continue with the next entry once the unsorted entry has percolated to its 
place (ie keep entries "0..n-1" sorted at all times). That should make the 
code cleaner too.

		Linus

  reply	other threads:[~2004-01-15 23:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-14  8:31 Andi Kleen
2004-01-14 23:23 ` Linus Torvalds
2004-01-15  7:48   ` Andi Kleen
2004-01-15 22:55     ` Linus Torvalds [this message]
2004-01-16  0:26       ` Peter Osterlund
2004-01-16 10:13       ` Andi Kleen
2004-01-18 20:47         ` Richard Henderson
2004-01-18 20:58           ` Andi Kleen
2004-01-19  0:41             ` Richard Henderson
2004-01-18 23:07           ` [PATCH] Add noinline attribute - new extable sort patch Andi Kleen
2004-01-19  0:52             ` Richard Henderson
2004-01-19  1:01               ` Andi Kleen
2004-01-19 11:26                 ` Rusty Russell
2004-01-15  0:35 ` [PATCH] Add noinline attribute Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0401151448200.2597@evo.osdl.org \
    --to=torvalds@osdl.org \
    --cc=ak@colin2.muc.de \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=jh@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®