mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Andi Kleen <ak@muc.de>
Cc: akpm@osdl.org, jh@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add noinline attribute
Date: Wed, 14 Jan 2004 15:23:35 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0401141519260.4500@evo.osdl.org> (raw)
In-Reply-To: <20040114083114.GA1784@averell>



On Wed, 14 Jan 2004, Andi Kleen wrote:
> 
> do_test_wp_bit cannot be inlined, otherwise the kernel doesn't boot
> because the exception tables get reordered. 

This patch seems to just hide the _real_ bug, which is that the exception 
table gets confused.

If the exception table is confused, you'll get oopses on bad user system 
call pointers, but since that is uncommon, you'll never see it under 
normal circumstances. This is the only exception that you'll always see.

So it sounds like you have a compiler combination that breaks the 
exception table totally for _any_ function called from any non-regular 
segment, and this just happens to be the only one you actually saw.

How about just fixing the exception table instead? A bogo-sort at boot 
time?

			Linus

  reply	other threads:[~2004-01-14 23:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-14  8:31 Andi Kleen
2004-01-14 23:23 ` Linus Torvalds [this message]
2004-01-15  7:48   ` Andi Kleen
2004-01-15 22:55     ` Linus Torvalds
2004-01-16  0:26       ` Peter Osterlund
2004-01-16 10:13       ` Andi Kleen
2004-01-18 20:47         ` Richard Henderson
2004-01-18 20:58           ` Andi Kleen
2004-01-19  0:41             ` Richard Henderson
2004-01-18 23:07           ` [PATCH] Add noinline attribute - new extable sort patch Andi Kleen
2004-01-19  0:52             ` Richard Henderson
2004-01-19  1:01               ` Andi Kleen
2004-01-19 11:26                 ` Rusty Russell
2004-01-15  0:35 ` [PATCH] Add noinline attribute Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0401141519260.4500@evo.osdl.org \
    --to=torvalds@osdl.org \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=jh@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®