mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] 2.6.2-mm1 - more -Wundef cleanup
@ 2004-02-06  3:51 Valdis.Kletnieks
  2004-02-06  4:27 ` Linux Capabilities and Other Security Models Documentation? Elikster
  0 siblings, 1 reply; 4+ messages in thread
From: Valdis.Kletnieks @ 2004-02-06  3:51 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Even after the patch I just sent, building with -Wundef still gets:

  CC      drivers/char/mem.o
In file included from drivers/char/mem.c:15:
include/linux/ftape.h:168:7: warning: "CONFIG_FT_ALT_FDC" is not defined

#elif CONFIG_FT_ALT_FDC == 1  /* CONFIG_FT_MACH2 */

The sort of whoops that -Wundef was intended to catch.

Further research shows that it's spurious - there's no obvious
reason for mem.c to even include ftape.h (or tpquic02.h for that
matter) - compiles fine, even compared 'gcc -E' with and without.

--- linux-2.6.2-mm1/drivers/char/mem.c.dist	2004-02-05 22:23:34.291328515 -0500
+++ linux-2.6.2-mm1/drivers/char/mem.c	2004-02-05 22:36:25.900847264 -0500
@@ -11,8 +11,6 @@
 #include <linux/config.h>
 #include <linux/mm.h>
 #include <linux/miscdevice.h>
-#include <linux/tpqic02.h>
-#include <linux/ftape.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
 #include <linux/mman.h>


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-02-07  0:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-06  3:51 [PATCH] 2.6.2-mm1 - more -Wundef cleanup Valdis.Kletnieks
2004-02-06  4:27 ` Linux Capabilities and Other Security Models Documentation? Elikster
2004-02-06  4:45   ` Darren Williams
2004-02-07  0:49     ` Chris Wright

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®