From: Chris Wright <chrisw@osdl.org>
To: Valdis.Kletnieks@vt.edu
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH} 2.6 and grsecurity
Date: Mon, 16 Feb 2004 18:15:46 -0800 [thread overview]
Message-ID: <20040216181546.A22989@build.pdx.osdl.net> (raw)
In-Reply-To: <200402170134.i1H1YIAW016949@turing-police.cc.vt.edu>; from Valdis.Kletnieks@vt.edu on Mon, Feb 16, 2004 at 08:34:17PM -0500
* Valdis.Kletnieks@vt.edu (Valdis.Kletnieks@vt.edu) wrote:
> Here's the patch, versioned against 2.6.3-rc3-mm1. Comments?
Aside of the dubious security value...the typical no #ifdefs apply here.
> +#ifdef CONFIG_SECURITY_RANDID
> + if (security_enable_randid)
> + id = ip_randomid();
> + else
> +#endif
e.g. move the ifdef to header and move the if(enable) bit to ip_randomid().
ditto for all similar cases below. it's not clear to me these are
particularly useful features though.
> + * 3. All advertising materials mentioning features or use of this software
> + * must display the following acknowledgement:
> + * This product includes software developed by Niels Provos.
Advertsing clause...this is not GPL compatible.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-02-17 2:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-17 1:34 Valdis.Kletnieks
2004-02-17 2:15 ` Chris Wright [this message]
2004-02-17 2:37 ` Valdis.Kletnieks
2004-02-17 2:45 ` Chris Wright
2004-02-17 6:13 ` James Morris
2004-02-17 6:48 ` Valdis.Kletnieks
2004-02-17 14:23 ` Martin Waitz
2004-02-17 14:53 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040216181546.A22989@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®