Re: [RFC][PATCH} 2.6 and grsecurity

[Chris Wright <chrisw@osdl.org>]

* Valdis.Kletnieks@vt.edu (Valdis.Kletnieks@vt.edu) wrote:
> OK.. I can do that easily enough - only reason I didn't was because that would
> force the inclusion of ip_randomid() and the corresponding call even when the
> feature wasn't selected, making it more intrusive (the 'else' clause is also the
> "when not configured at all" code - moving the whole if/then/else to another
> function was more intrusive, to my thinking..)

could be

	#ifndef CONFIG_RANDID
	#define ip_randomid(x)  (x)
	#else
	int ip_randomid(int id)
	{
		if(security_enable...)
			return random_one();
		return id;
	}
	#endif

or somesuch, you get the idea.

> > > + * 3. All advertising materials mentioning features or use of this softwar
> e
> > > + *    must display the following acknowledgement:
> > > + *    This product includes software developed by Niels Provos.
> > 
> > Advertsing clause...this is not GPL compatible.
> 
> Thanks for spotting that.  It's the same way in grsecurity's patch - do they
> have an issue as well?  Or they OK because they're only doing a separately
> distributed patch?

I suspect yes, but, of course, IANAL ;-)

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net