From: Martin Waitz <tali@admingilde.org>
To: Valdis.Kletnieks@vt.edu
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH} 2.6 and grsecurity
Date: Tue, 17 Feb 2004 15:23:33 +0100 [thread overview]
Message-ID: <20040217142333.GF27996@admingilde.org> (raw)
In-Reply-To: <200402170134.i1H1YIAW016949@turing-police.cc.vt.edu>
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
hi :)
On Mon, Feb 16, 2004 at 08:34:17PM -0500, Valdis.Kletnieks@vt.edu wrote:
> spin_lock_bh(&inet_peer_idlock);
> - id = p->ip_id_count;
> +#ifdef CONFIG_SECURITY_RANDID
> + if (security_enable_randid)
> + id = ip_randomid();
> + else
> +#endif
> + id = p->ip_id_count;
you could #define security_enable_* to 0 when CONFIG_SECURITY_*
is disabled. thay way you don't need the ugly #ifdef in the .c file
on the other hand, why do one need a syscall anyway.
only to justify the existence of some ugly lockdown mode?
well, why make it even configurable?
eigther it increases security, then by all means: enable it
unconditionally;
or it doesn't increase security, and why do we need it then?
--
CU, / Friedrich-Alexander University Erlangen, Germany
Martin Waitz // Department of Computer Science 12 _________
______________/// - - - - - - - - - - - - - - - - - - - - ///
dies ist eine manuell generierte mail, sie beinhaltet //
tippfehler und ist auch ohne grossbuchstaben gueltig. /
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-02-17 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-17 1:34 Valdis.Kletnieks
2004-02-17 2:15 ` Chris Wright
2004-02-17 2:37 ` Valdis.Kletnieks
2004-02-17 2:45 ` Chris Wright
2004-02-17 6:13 ` James Morris
2004-02-17 6:48 ` Valdis.Kletnieks
2004-02-17 14:23 ` Martin Waitz [this message]
2004-02-17 14:53 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040217142333.GF27996@admingilde.org \
--to=tali@admingilde.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®