* i2c on alpha - used but not available in 2.6.3 @ 2004-02-25 16:08 Jakub Bogusz 2004-02-25 16:14 ` Christoph Hellwig 0 siblings, 1 reply; 6+ messages in thread From: Jakub Bogusz @ 2004-02-25 16:08 UTC (permalink / raw) To: linux-kernel Are i2c drivers valid on alpha? They are not available because drivers/i2c/Kconfig (nor drivers/Kconfig which includes it) is not included from arch/alpha/Kconfig. But many drivers making use of i2c can be enabled - and build with unresolved symbols (about 50 warnings - mostly in media/video drivers). I checked that adding including of drivers/i2c/Kconfig to arch/alpha/Kconfig everything build and all remaining unresolved symbols fade away. -- Jakub Bogusz http://cyber.cs.net.pl/~qboosh/ PLD Team http://www.pld-linux.org/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c on alpha - used but not available in 2.6.3 2004-02-25 16:08 i2c on alpha - used but not available in 2.6.3 Jakub Bogusz @ 2004-02-25 16:14 ` Christoph Hellwig 2004-02-26 10:53 ` Jakub Bogusz 0 siblings, 1 reply; 6+ messages in thread From: Christoph Hellwig @ 2004-02-25 16:14 UTC (permalink / raw) To: Jakub Bogusz; +Cc: linux-kernel On Wed, Feb 25, 2004 at 05:08:33PM +0100, Jakub Bogusz wrote: > I checked that adding including of drivers/i2c/Kconfig to arch/alpha/Kconfig > everything build and all remaining unresolved symbols fade away. I'd just switch alpha to use drivers/Kconfig ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c on alpha - used but not available in 2.6.3 2004-02-25 16:14 ` Christoph Hellwig @ 2004-02-26 10:53 ` Jakub Bogusz 2004-02-26 10:57 ` Christoph Hellwig 0 siblings, 1 reply; 6+ messages in thread From: Jakub Bogusz @ 2004-02-26 10:53 UTC (permalink / raw) To: Christoph Hellwig, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1116 bytes --] On Wed, Feb 25, 2004 at 04:14:41PM +0000, Christoph Hellwig wrote: > On Wed, Feb 25, 2004 at 05:08:33PM +0100, Jakub Bogusz wrote: > > I checked that adding including of drivers/i2c/Kconfig to arch/alpha/Kconfig > > everything build and all remaining unresolved symbols fade away. > > I'd just switch alpha to use drivers/Kconfig Like in the attached patch? I found few more differences: - beside drivers/i2c there was no drivers/misc and drivers/telephony in alpha/Kconfig - was this intentional or accidental? drivers/misc currently contains only IBM_ASM, which looks like some hardware-specific driver - maybe it should be available only on some arch(s)? - on alpha drivers/parport was placed in "System setup" menu - but I suppose it can be moved to standard location without problems - drivers/message/fusion was included only conditionaly, depending on PCI option (in drivers/Kconfig it's unconditional). If message/fusion requires PCI, maybe it should have "depends on PCI" in its Kconfig? -- Jakub Bogusz http://cyber.cs.net.pl/~qboosh/ PLD Team http://www.pld-linux.org/ [-- Attachment #2: linux-alpha-use-device-Kconfig.patch --] [-- Type: text/plain, Size: 998 bytes --] --- linux-2.6.3/arch/alpha/Kconfig.orig 2004-02-24 11:07:49.000000000 +0100 +++ linux-2.6.3/arch/alpha/Kconfig 2004-02-26 11:13:49.000000000 +0100 @@ -596,51 +596,12 @@ source "fs/Kconfig.binfmt" -source "drivers/parport/Kconfig" - endmenu -source "drivers/base/Kconfig" - -source "drivers/mtd/Kconfig" - -source "drivers/pnp/Kconfig" - -source "drivers/block/Kconfig" - -source "drivers/md/Kconfig" - -source "drivers/ide/Kconfig" - -source "drivers/scsi/Kconfig" - -if PCI -source "drivers/message/fusion/Kconfig" -endif - -source "drivers/ieee1394/Kconfig" - -source "net/Kconfig" - -source "drivers/isdn/Kconfig" - -source "drivers/cdrom/Kconfig" - -source "drivers/input/Kconfig" - -source "drivers/char/Kconfig" - -#source drivers/misc/Config.in -source "drivers/media/Kconfig" +source "drivers/Kconfig" source "fs/Kconfig" -source "drivers/video/Kconfig" - -source "sound/Kconfig" - -source "drivers/usb/Kconfig" - source "arch/alpha/oprofile/Kconfig" menu "Kernel hacking" ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c on alpha - used but not available in 2.6.3 2004-02-26 10:53 ` Jakub Bogusz @ 2004-02-26 10:57 ` Christoph Hellwig 2004-02-26 11:18 ` Jakub Bogusz 0 siblings, 1 reply; 6+ messages in thread From: Christoph Hellwig @ 2004-02-26 10:57 UTC (permalink / raw) To: Jakub Bogusz; +Cc: Christoph Hellwig, linux-kernel On Thu, Feb 26, 2004 at 11:53:57AM +0100, Jakub Bogusz wrote: > - beside drivers/i2c there was no drivers/misc and drivers/telephony in > alpha/Kconfig - was this intentional or accidental? > > drivers/misc currently contains only IBM_ASM, which looks like some > hardware-specific driver - maybe it should be available only on some > arch(s)? drivers/misc/ is empty here, and until we have some policy decision it should stay that way. What tree do you look at? > - on alpha drivers/parport was placed in "System setup" menu - but > I suppose it can be moved to standard location without problems Yes. > - drivers/message/fusion was included only conditionaly, depending on > PCI option (in drivers/Kconfig it's unconditional). > If message/fusion requires PCI, maybe it should have "depends on PCI" > in its Kconfig? Yes, this is probably worth fixing. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c on alpha - used but not available in 2.6.3 2004-02-26 10:57 ` Christoph Hellwig @ 2004-02-26 11:18 ` Jakub Bogusz 2004-02-26 11:23 ` Christoph Hellwig 0 siblings, 1 reply; 6+ messages in thread From: Jakub Bogusz @ 2004-02-26 11:18 UTC (permalink / raw) To: Christoph Hellwig, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1318 bytes --] On Thu, Feb 26, 2004 at 10:57:37AM +0000, Christoph Hellwig wrote: > On Thu, Feb 26, 2004 at 11:53:57AM +0100, Jakub Bogusz wrote: > > - beside drivers/i2c there was no drivers/misc and drivers/telephony in > > alpha/Kconfig - was this intentional or accidental? > > > > drivers/misc currently contains only IBM_ASM, which looks like some > > hardware-specific driver - maybe it should be available only on some > > arch(s)? > > drivers/misc/ is empty here, and until we have some policy decision it > should stay that way. What tree do you look at? Uh, haven't noticed this comes from IBM-RAS patches in distribution tree. OK, so drivers/misc doesn't make any difference for now. > > - on alpha drivers/parport was placed in "System setup" menu - but > > I suppose it can be moved to standard location without problems > > Yes. > > > - drivers/message/fusion was included only conditionaly, depending on > > PCI option (in drivers/Kconfig it's unconditional). > > If message/fusion requires PCI, maybe it should have "depends on PCI" > > in its Kconfig? > > Yes, this is probably worth fixing. OK, added the change to patch. So is this patch correct now and would be accepted to Linux 2.6 tree? -- Jakub Bogusz http://cyber.cs.net.pl/~qboosh/ PLD Team http://www.pld-linux.org/ [-- Attachment #2: linux-alpha-use-device-Kconfig.patch --] [-- Type: text/plain, Size: 1466 bytes --] --- linux-2.6.3/arch/alpha/Kconfig.orig 2004-02-24 11:07:49.000000000 +0100 +++ linux-2.6.3/arch/alpha/Kconfig 2004-02-26 11:13:49.000000000 +0100 @@ -596,51 +596,12 @@ source "fs/Kconfig.binfmt" -source "drivers/parport/Kconfig" - endmenu -source "drivers/base/Kconfig" - -source "drivers/mtd/Kconfig" - -source "drivers/pnp/Kconfig" - -source "drivers/block/Kconfig" - -source "drivers/md/Kconfig" - -source "drivers/ide/Kconfig" - -source "drivers/scsi/Kconfig" - -if PCI -source "drivers/message/fusion/Kconfig" -endif - -source "drivers/ieee1394/Kconfig" - -source "net/Kconfig" - -source "drivers/isdn/Kconfig" - -source "drivers/cdrom/Kconfig" - -source "drivers/input/Kconfig" - -source "drivers/char/Kconfig" - -#source drivers/misc/Config.in -source "drivers/media/Kconfig" +source "drivers/Kconfig" source "fs/Kconfig" -source "drivers/video/Kconfig" - -source "sound/Kconfig" - -source "drivers/usb/Kconfig" - source "arch/alpha/oprofile/Kconfig" menu "Kernel hacking" --- linux-2.6.3/drivers/message/fusion/Kconfig.orig 2004-02-18 04:59:59.000000000 +0100 +++ linux-2.6.3/drivers/message/fusion/Kconfig 2004-02-26 12:11:09.000000000 +0100 @@ -3,7 +3,7 @@ config FUSION tristate "Fusion MPT (base + ScsiHost) drivers" - depends on BLK_DEV_SD + depends on BLK_DEV_SD && PCI ---help--- LSI Logic Fusion(TM) Message Passing Technology (MPT) device support provides high performance SCSI host initiator, and LAN [1] interface ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c on alpha - used but not available in 2.6.3 2004-02-26 11:18 ` Jakub Bogusz @ 2004-02-26 11:23 ` Christoph Hellwig 0 siblings, 0 replies; 6+ messages in thread From: Christoph Hellwig @ 2004-02-26 11:23 UTC (permalink / raw) To: Jakub Bogusz; +Cc: Christoph Hellwig, linux-kernel On Thu, Feb 26, 2004 at 12:18:30PM +0100, Jakub Bogusz wrote: > OK, added the change to patch. > > So is this patch correct now and would be accepted to Linux 2.6 tree? fine with me. Ping akpm and linus for it. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-02-26 11:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2004-02-25 16:08 i2c on alpha - used but not available in 2.6.3 Jakub Bogusz 2004-02-25 16:14 ` Christoph Hellwig 2004-02-26 10:53 ` Jakub Bogusz 2004-02-26 10:57 ` Christoph Hellwig 2004-02-26 11:18 ` Jakub Bogusz 2004-02-26 11:23 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®