From: "Hemmann, Volker Armin" <volker.hemmann@heim9.tu-clausthal.de>
To: Dave Jones <davej@redhat.com>,
Bjoern Michaelsen <bmichaelsen@gmx.de>,
linux-kernel@vger.kernel.org
Subject: Re: AGP problem SiS 746FX Linux 2.6.5-rc3
Date: Tue, 6 Apr 2004 22:06:38 +0200 [thread overview]
Message-ID: <200404062206.38731.volker.hemmann@heim10.tu-clausthal.de> (raw)
In-Reply-To: <20040406192447.GA1100@redhat.com>
Hi,
On Tuesday 06 April 2004 21:24, Dave Jones wrote:
> On Tue, Apr 06, 2004 at 08:44:06PM +0200, Hemmann, Volker Armin wrote:
> > I rebooted.
> > Same error, uname -r:
> > Linux energy.heim10.tu-clausthal.de 2.6.5 #1 Tue Apr 6 20:26:45 CEST
> > 2004 i686 AMD Athlon(tm) XP 2000+ AuthenticAMD GNU/Linux
> >
> > So yes, I am pretty sure, that I am innocent ;o)
>
> Ok, what happens if you nuke the ..
>
> } else {
> sis_driver.agp_enable=sis_648_enable;
> }
>
> in sis_get_driver() ?
> That should put things back to 2.6.4 style "working" order for you.
>
> Dave
more bad news, it did not.
It compiled and the module loaded, but with the error again.
I copied over tht sis-agp.c from 2.6.5-rc3 that was modified with your patches
last week and AGP is now working again.
I did a diff between the modified sis-agp.c from 2.6.5 (sis-agp.bak, without
the else) and the working sis-agp.c from 2.6.5-rc3 (now in 2.6.5):
bash-2.05b$ diff
-u /usr/src/linux/drivers/char/agp/sis-agp.bak /usr/src/linux-2.6.5-rc3/drivers/char/agp/sis-agp.c
--- /usr/src/linux/drivers/char/agp/sis-agp.bak 2004-04-06 21:43:53.000000000
+0200
+++ /usr/src/linux-2.6.5-rc3/drivers/char/agp/sis-agp.c 2004-04-02
03:21:43.000000000 +0200
@@ -92,17 +92,17 @@
<snap only whitespace difference>
@@ -225,9 +225,11 @@
static void __devinit sis_get_driver(struct agp_bridge_data *bridge)
{
- if (bridge->dev->device == PCI_DEVICE_ID_SI_648 ||
- bridge->dev->device == PCI_DEVICE_ID_SI_746) {
- if (agp_bridge->major_version == 3) {
+ if (bridge->dev->device == PCI_DEVICE_ID_SI_648 ||
+ bridge->dev->device == PCI_DEVICE_ID_SI_746) {
+ if (agp_bridge->major_version == 3 &&
agp_bridge->minor_version < 5) {
+ sis_driver.agp_enable=sis_648_enable;
+ } else {
sis_driver.agp_enable =
sis_648_enable;
sis_driver.aperture_sizes =
agp3_generic_sizes;
sis_driver.size_type =
U16_APER_SIZE;
Glück Auf
Volker
--
Conclusions
In a straight-up fight, the Empire squashes the Federation like a bug. Even
with its numerical advantage removed, the Empire would still squash the
Federation like a bug. Accept it. -Michael Wong
next prev parent reply other threads:[~2004-04-06 20:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 3:19 Bjoern Michaelsen
2004-04-06 13:50 ` Dave Jones
2004-04-06 18:04 ` Hemmann, Volker Armin
2004-04-06 18:11 ` Dave Jones
2004-04-06 18:44 ` Hemmann, Volker Armin
2004-04-06 19:24 ` Dave Jones
2004-04-06 20:06 ` Hemmann, Volker Armin [this message]
2004-04-06 20:31 ` Dave Jones
2004-04-06 20:37 ` Hemmann, Volker Armin
2004-04-06 20:48 ` Dave Jones
2004-04-06 21:04 ` Hemmann, Volker Armin
2004-04-06 21:08 ` Dave Jones
2004-04-06 22:01 ` Hemmann, Volker Armin
2004-04-06 22:14 ` Dave Jones
2004-04-06 22:26 ` Hemmann, Volker Armin
2004-04-06 23:24 ` Bjoern Michaelsen
[not found] <1HPrP-5sW-3@gated-at.bofh.it>
[not found] ` <1I53J-1k7-57@gated-at.bofh.it>
[not found] ` <1I5wD-1Gx-15@gated-at.bofh.it>
[not found] ` <1I5wH-1Gx-35@gated-at.bofh.it>
[not found] ` <1I5Q0-1Vt-7@gated-at.bofh.it>
[not found] ` <1obEA-82t-11@gated-at.bofh.it>
2004-04-17 15:44 ` Oliver Schoett
-- strict thread matches above, loose matches on Subject: below --
2004-04-01 17:00 Hemmann, Volker Armin
2004-04-01 17:10 ` Dave Jones
2004-04-01 18:03 ` Hemmann, Volker Armin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404062206.38731.volker.hemmann@heim10.tu-clausthal.de \
--to=volker.hemmann@heim9.tu-clausthal.de \
--cc=bmichaelsen@gmx.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®