* IA32 (2.6.5 - 2004-04-12.22.30) - 2 New warnings (gcc 3.2.2)
@ 2004-04-13 14:31 John Cherry
2004-04-13 15:37 ` Don Koch
2004-04-13 18:11 ` Don Koch
0 siblings, 2 replies; 3+ messages in thread
From: John Cherry @ 2004-04-13 14:31 UTC (permalink / raw)
To: linux-kernel
drivers/char/cyclades.c:686: warning: `cy_get_user' defined but not used
drivers/video/fbmem.c:914: warning: passing arg 1 of `copy_from_user' discards qualifiers from pointer target type
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: IA32 (2.6.5 - 2004-04-12.22.30) - 2 New warnings (gcc 3.2.2)
2004-04-13 14:31 IA32 (2.6.5 - 2004-04-12.22.30) - 2 New warnings (gcc 3.2.2) John Cherry
@ 2004-04-13 15:37 ` Don Koch
2004-04-13 18:11 ` Don Koch
1 sibling, 0 replies; 3+ messages in thread
From: Don Koch @ 2004-04-13 15:37 UTC (permalink / raw)
To: John Cherry; +Cc: linux-kernel, aardvark
> drivers/char/cyclades.c:686: warning: `cy_get_user' defined but not used
I sent a patch for this to the janitor's list.
--
Don Koch
http://www.krl.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: IA32 (2.6.5 - 2004-04-12.22.30) - 2 New warnings (gcc 3.2.2)
2004-04-13 14:31 IA32 (2.6.5 - 2004-04-12.22.30) - 2 New warnings (gcc 3.2.2) John Cherry
2004-04-13 15:37 ` Don Koch
@ 2004-04-13 18:11 ` Don Koch
1 sibling, 0 replies; 3+ messages in thread
From: Don Koch @ 2004-04-13 18:11 UTC (permalink / raw)
To: John Cherry; +Cc: linux-kernel
> drivers/video/fbmem.c:914: warning: passing arg 1 of `copy_from_user' discards qualifiers from pointer target type
The following patch fixes the warning - the "data" field is "const"
for apparently varying definitions of the word "const" ;-).
===== fbmem.c 1.95 vs edited =====
--- 1.94/drivers/video/fbmem.c Thu Mar 25 12:57:01 2004
+++ edited/fbmem.c Tue Apr 13 13:17:56 2004
@@ -911,7 +911,7 @@
return -ENOMEM;
}
- if (copy_from_user(cursor.image.data, sprite->image.data, size) ||
+ if (copy_from_user((char *)cursor.image.data, sprite->image.data, size) ||
copy_from_user(cursor.mask, sprite->mask, size)) {
kfree(cursor.image.data);
kfree(cursor.mask);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-04-13 18:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-13 14:31 IA32 (2.6.5 - 2004-04-12.22.30) - 2 New warnings (gcc 3.2.2) John Cherry
2004-04-13 15:37 ` Don Koch
2004-04-13 18:11 ` Don Koch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®