[PATCH] Kconfig.debug family

[PATCH] Kconfig.debug family

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 2523 bytes --]


Localizes kernel debug options in lib/Kconfig.debug.
Puts arch-specific debug options in $ARCH/Kconfig.debug.

updated for 2.6.6-rc2

http://developer.osdl.org/rddunlap/patches/kconf_debug_1file_266rc2.patch

Also included here as a gzipped attachment.

 arch/alpha/Kconfig           |  104 ---------------------
 arch/alpha/Kconfig.debug     |   54 +++++++++++
 arch/arm/Kconfig             |  160 --------------------------------
 arch/arm/Kconfig.debug       |  113 +++++++++++++++++++++++
 arch/arm26/Kconfig           |  113 -----------------------
 arch/arm26/Kconfig.debug     |   58 +++++++++++
 arch/cris/Kconfig            |   14 --
 arch/cris/Kconfig.debug      |   14 ++
 arch/h8300/Kconfig           |   72 --------------
 arch/h8300/Kconfig.debug     |   66 +++++++++++++
 arch/i386/Kconfig            |  125 -------------------------
 arch/i386/Kconfig.debug      |   14 ++
 arch/ia64/Kconfig            |  114 -----------------------
 arch/ia64/Kconfig.debug      |   62 ++++++++++++
 arch/m68k/Kconfig            |   38 -------
 arch/m68k/Kconfig.debug      |    8 +
 arch/m68knommu/Kconfig       |   55 -----------
 arch/m68knommu/Kconfig.debug |   41 ++++++++
 arch/mips/Kconfig            |  119 ------------------------
 arch/mips/Kconfig.debug      |   66 +++++++++++++
 arch/parisc/Kconfig          |   49 ---------
 arch/parisc/Kconfig.debug    |    5 +
 arch/ppc/Kconfig             |  124 -------------------------
 arch/ppc/Kconfig.debug       |   71 ++++++++++++++
 arch/ppc64/Kconfig           |   80 ----------------
 arch/ppc64/Kconfig.debug     |   26 +++++
 arch/s390/Kconfig            |   56 -----------
 arch/s390/Kconfig.debug      |    6 +
 arch/sh/Kconfig              |  140 ----------------------------
 arch/sh/Kconfig.debug        |  110 ++++++++++++++++++++++
 arch/sparc/Kconfig           |   72 --------------
 arch/sparc/Kconfig.debug     |   13 ++
 arch/sparc64/Kconfig         |  104 ---------------------
 arch/sparc64/Kconfig.debug   |   37 +++++++
 arch/um/Kconfig              |   60 ------------
 arch/um/Kconfig.debug        |   34 ++++++
 arch/v850/Kconfig            |   29 -----
 arch/v850/Kconfig.debug      |    9 +
 arch/x86_64/Kconfig          |  101 --------------------
 arch/x86_64/Kconfig.debug    |   46 +++++++++
 init/Kconfig                 |    8 -
 lib/Kconfig.debug            |  211 +++++++++++++++++++++++++++++++++++++++++++
 42 files changed, 1084 insertions(+), 1717 deletions(-)


Like it, kill/drop it, fix (what?) problems, ... ?

--
~Randy

[-- Attachment #2: kconf_debug_1file_266rc2.patch.gz --]
[-- Type: application/octet-stream, Size: 16467 bytes --]

Re: [PATCH] Kconfig.debug family

[Zwane Mwaikambo]

On Wed, 21 Apr 2004, Randy.Dunlap wrote:

>  lib/Kconfig.debug            |  211 +++++++++++++++++++++++++++++++++++++++++++
>  42 files changed, 1084 insertions(+), 1717 deletions(-)
>
>
> Like it, kill/drop it, fix (what?) problems, ... ?

Looks good to me, can we convince a certain someone? ;)

Re: [PATCH] Kconfig.debug family

[Andrew Morton]

"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
> Localizes kernel debug options in lib/Kconfig.debug.
>  Puts arch-specific debug options in $ARCH/Kconfig.debug.
> 
>  updated for 2.6.6-rc2
> 
>  http://developer.osdl.org/rddunlap/patches/kconf_debug_1file_266rc2.patch
> 
>  Also included here as a gzipped attachment.
> 
> ...
>   42 files changed, 1084 insertions(+), 1717 deletions(-)
> 
> 
>  Like it, kill/drop it, fix (what?) problems, ... ?

It breaks at least six patches from -mm and I'm too lazy to do anything
about it.

Please resend after 2.6.6.

Re: [PATCH] Kconfig.debug family

[Tom Rini]

On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:

> Localizes kernel debug options in lib/Kconfig.debug.
> Puts arch-specific debug options in $ARCH/Kconfig.debug.
[snip]
>  arch/ppc/Kconfig             |  124 -------------------------
>  arch/ppc/Kconfig.debug       |   71 ++++++++++++++

OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
right now.

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: [PATCH] Kconfig.debug family

[Randy.Dunlap]

On Mon, 26 Apr 2004 09:42:52 -0700 Tom Rini wrote:

| On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:
| 
| > Localizes kernel debug options in lib/Kconfig.debug.
| > Puts arch-specific debug options in $ARCH/Kconfig.debug.
| [snip]
| >  arch/ppc/Kconfig             |  124 -------------------------
| >  arch/ppc/Kconfig.debug       |   71 ++++++++++++++
| 
| OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
| right now.


Thanks.  I moved it to under Processor options, before Platform
options.  Is that OK?

Updated patch is here:
  http://developer.osdl.org/rddunlap/patches/kdebug1file_266rc2_v2.patch
(applies to 2.6.6-rc3 with a few offsets)

Waiting for 2.6.6-final...

--
~Randy
(Again.  Sometimes I think ln -s /usr/src/linux/.config .signature) -- akpm

Re: [PATCH] Kconfig.debug family

[Tom Rini]

On Thu, Apr 29, 2004 at 08:38:20AM -0700, Randy.Dunlap wrote:

> On Mon, 26 Apr 2004 09:42:52 -0700 Tom Rini wrote:
> 
> | On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:
> | 
> | > Localizes kernel debug options in lib/Kconfig.debug.
> | > Puts arch-specific debug options in $ARCH/Kconfig.debug.
> | [snip]
> | >  arch/ppc/Kconfig             |  124 -------------------------
> | >  arch/ppc/Kconfig.debug       |   71 ++++++++++++++
> | 
> | OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
> | right now.
> 
> 
> Thanks.  I moved it to under Processor options, before Platform
> options.  Is that OK?

Yup, thanks.

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: [PATCH] Kconfig.debug family

[Bartlomiej Zolnierkiewicz]

On Thursday 29 of April 2004 17:38, Randy.Dunlap wrote:
> On Mon, 26 Apr 2004 09:42:52 -0700 Tom Rini wrote:
> | On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:
> | > Localizes kernel debug options in lib/Kconfig.debug.
> | > Puts arch-specific debug options in $ARCH/Kconfig.debug.
> |
> | [snip]
> |
> | >  arch/ppc/Kconfig             |  124 -------------------------
> | >  arch/ppc/Kconfig.debug       |   71 ++++++++++++++
> |
> | OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
> | right now.
>
> Thanks.  I moved it to under Processor options, before Platform
> options.  Is that OK?
>
> Updated patch is here:
>   http://developer.osdl.org/rddunlap/patches/kdebug1file_266rc2_v2.patch
> (applies to 2.6.6-rc3 with a few offsets)
>
> Waiting for 2.6.6-final...

I guess it is not a final patch?

Only on x86 it does a proper thing:

arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug

Cheers,
Bartlomiej

Re: [PATCH] Kconfig.debug family

[Randy.Dunlap]

On Thu, 29 Apr 2004 18:42:23 +0200 Bartlomiej Zolnierkiewicz wrote:

| On Thursday 29 of April 2004 17:38, Randy.Dunlap wrote:
| > On Mon, 26 Apr 2004 09:42:52 -0700 Tom Rini wrote:
| > | On Wed, Apr 21, 2004 at 08:51:40PM -0700, Randy.Dunlap wrote:
| > | > Localizes kernel debug options in lib/Kconfig.debug.
| > | > Puts arch-specific debug options in $ARCH/Kconfig.debug.
| > |
| > | [snip]
| > |
| > | >  arch/ppc/Kconfig             |  124 -------------------------
| > | >  arch/ppc/Kconfig.debug       |   71 ++++++++++++++
| > |
| > | OCP shouldn't be moved into Kconfig.debug, it's just in an odd location
| > | right now.
| >
| > Thanks.  I moved it to under Processor options, before Platform
| > options.  Is that OK?
| >
| > Updated patch is here:
| >   http://developer.osdl.org/rddunlap/patches/kdebug1file_266rc2_v2.patch
| > (applies to 2.6.6-rc3 with a few offsets)
| >
| > Waiting for 2.6.6-final...
| 
| I guess it is not a final patch?

Well, it hasn't been accepted.

| Only on x86 it does a proper thing:
| 
| arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug

That's because I goofed up... it's the wrong patch.

I was trying something that someone suggested (You!) and it didn't
work out in a desirable way as far as how it's presented in
{x,menu}config, so I need to fix that (i386 part) and then you
can complain some more.  :)

--
~Randy

Re: [PATCH] Kconfig.debug family

[Bartlomiej Zolnierkiewicz]

On Thursday 29 of April 2004 18:51, Randy.Dunlap wrote:
> On Thu, 29 Apr 2004 18:42:23 +0200 Bartlomiej Zolnierkiewicz wrote:

> | Only on x86 it does a proper thing:
> |
> | arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug
>
> That's because I goofed up... it's the wrong patch.
>
> I was trying something that someone suggested (You!) and it didn't

:)

> work out in a desirable way as far as how it's presented in
> {x,menu}config, so I need to fix that (i386 part) and then you

In your previous patch (vs 2.6.5) there was only one "Kernel hacking" menu,
in this one there are two menus: "Kernel hacking" and "X86 kernel hacking".

I hacked it quickly and I have one menu again (on x86 arch specific options
are not configurable) so I also hacked+checked  ppc and 'make menuconfig'
looks OK).  Did I miss something?

diff -u linux-2.6.6-rc2-bk4-bzolnier/arch/i386/Kconfig.debug linux-2.6.6-rc2-bk4-bzolnier/arch/i386/Kconfig.debug
--- linux-2.6.6-rc2-bk4-bzolnier/arch/i386/Kconfig.debug	2004-04-29 20:31:57.358189632 +0200
+++ linux-2.6.6-rc2-bk4-bzolnier/arch/i386/Kconfig.debug	2004-04-29 20:45:11.884403288 +0200
@@ -1,6 +1,7 @@
-source "lib/Kconfig.debug"
 
-menu "X86 kernel hacking"
+menu "Kernel hacking"
+
+source "lib/Kconfig.debug"
 
 config X86_FIND_SMP_CONFIG
 	bool
diff -u linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig
--- linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig	2004-04-29 20:31:57.396183856 +0200
+++ linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig	2004-04-29 20:45:49.703653888 +0200
@@ -1108,7 +1108,7 @@
 
 source "lib/Kconfig"
 
-source "lib/Kconfig.debug"
+source "arch/ppc/Kconfig.debug"
 
 source "security/Kconfig"
 
diff -u linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig.debug linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig.debug
--- linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig.debug	2004-04-29 20:31:57.397183704 +0200
+++ linux-2.6.6-rc2-bk4-bzolnier/arch/ppc/Kconfig.debug	2004-04-29 20:45:33.027189096 +0200
@@ -1,4 +1,6 @@
-menu "PPC kernel hacking"
+menu "Kernel hacking"
+
+source "lib/Kconfig.debug"
 
 config KGDB
 	bool "Include kgdb kernel debugger"
@@ -66 +67,0 @@
-
diff -u linux-2.6.6-rc2-bk4-bzolnier/lib/Kconfig.debug linux-2.6.6-rc2-bk4-bzolnier/lib/Kconfig.debug
--- linux-2.6.6-rc2-bk4-bzolnier/lib/Kconfig.debug	2004-04-29 20:31:57.439177320 +0200
+++ linux-2.6.6-rc2-bk4-bzolnier/lib/Kconfig.debug	2004-04-29 20:39:43.907263392 +0200
@@ -1,6 +1,4 @@
-# Generic debug menu
-
-menu "Kernel hacking"
+# Generic debug options
 
 config DEBUG_KERNEL
 	bool "Kernel debugging"
@@ -97,7 +95,7 @@
 	  debugging info resulting in a larger kernel image.
 	  Say Y here only if you plan to use gdb to debug the kernel.
 	  If you don't debug the kernel, you can say N.
-	  
+
 config FRAME_POINTER
 	bool "Compile the kernel with frame pointers"
 	depends on DEBUG_KERNEL && (!ARM && !ARM26 && !X86_64 && !S390 && !V850 && !SPARC64)
@@ -148,3 +145,0 @@
-
-endmenu
-

> can complain some more.  :)

:)

Bartlomiej

Re: [PATCH] Kconfig.debug family

[Randy.Dunlap]

On Thu, 29 Apr 2004 20:54:49 +0200 Bartlomiej Zolnierkiewicz wrote:

| On Thursday 29 of April 2004 18:51, Randy.Dunlap wrote:
| > On Thu, 29 Apr 2004 18:42:23 +0200 Bartlomiej Zolnierkiewicz wrote:
| 
| > | Only on x86 it does a proper thing:
| > |
| > | arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug
| >
| > That's because I goofed up... it's the wrong patch.
| >
| > I was trying something that someone suggested (You!) and it didn't
| 
| :)
| 
| > work out in a desirable way as far as how it's presented in
| > {x,menu}config, so I need to fix that (i386 part) and then you
| 
| In your previous patch (vs 2.6.5) there was only one "Kernel hacking" menu,
| in this one there are two menus: "Kernel hacking" and "X86 kernel hacking".
| 
| I hacked it quickly and I have one menu again (on x86 arch specific options
| are not configurable) so I also hacked+checked  ppc and 'make menuconfig'
| looks OK).  Did I miss something?

Hm, looks good to me at first testing, I'll do the other arches.

Thanks much.

--
~Randy

Re: [PATCH] Kconfig.debug family (v3-bart)

[Randy.Dunlap]

On Thu, 29 Apr 2004 20:54:49 +0200 Bartlomiej Zolnierkiewicz wrote:

| On Thursday 29 of April 2004 18:51, Randy.Dunlap wrote:
| > On Thu, 29 Apr 2004 18:42:23 +0200 Bartlomiej Zolnierkiewicz wrote:
| 
| > | Only on x86 it does a proper thing:
| > |
| > | arch/<arch>/Kconfig -> arch/<arch>/Kconfig.debug -> lib/Kconfig.debug
| >
| > That's because I goofed up... it's the wrong patch.
| >
| > I was trying something that someone suggested (You!) and it didn't
| 
| :)
| 
| > work out in a desirable way as far as how it's presented in
| > {x,menu}config, so I need to fix that (i386 part) and then you
| 
| In your previous patch (vs 2.6.5) there was only one "Kernel hacking" menu,
| in this one there are two menus: "Kernel hacking" and "X86 kernel hacking".
| 
| I hacked it quickly and I have one menu again (on x86 arch specific options
| are not configurable) so I also hacked+checked  ppc and 'make menuconfig'
| looks OK).  Did I miss something?

Bart's changes still look good.  I've updated the entire patch
to use that model.  It's available here:
  http://developer.osdl.org/rddunlap/patches/kdebug1menu_266rc2_v3.patch


Any more comments before 2.6.6?

Thanks,
--
~Randy