sysfs warning + spinlock BUG in typhoon radio

sysfs warning + spinlock BUG in typhoon radio

[Randy.Dunlap]

2.6.6:


Calling initcall 0xc10bc558: typhoon_init+0x0/0x12a()
Typhoon Radio Card driver v0.1
CLASS: registering class device: ID = 'radio2'
class_hotplug - name = radio2
videodev: "Typhoon Radio" has no release callback. Please fix your driver for proper sysfs support, see http://lwn.net/Articles/36850/
radio-typhoon: port 0x316.
radio-typhoon: mute frequency is 87500 kHz.
eip: c0b946cc
------------[ cut here ]------------
kernel BUG at include/asm/spinlock.h:120!
invalid operand: 0000 [#1]
PREEMPT SMP DEBUG_PAGEALLOC
CPU:    0
EIP:    0060:[<c0b94894>]    Not tainted
EFLAGS: 00010096   (2.6.6) 
EIP is at __down+0x1c8/0x1d6
eax: 0000000e   ebx: 00000000   ecx: c0d8c658   edx: 00000001
esi: c0e09258   edi: 00000296   ebp: c25aff5c   esp: c25aff14
ds: 007b   es: 007b   ss: 0068
Process swapper (pid: 1, threadinfo=c25ae000 task=f7f9da60)
Stack: c0bf2aa9 c0b946cc c0e09260 f7f9da60 c0124522 00012cf9 00012cf9 00000000 
       f7f9da60 c011ee6a 00000000 00000000 00012cf9 c25aff74 c0124ac4 00000000 
       c0e09258 c0e09240 c25aff70 c0b94ab7 c0e09258 00000001 00000000 c25aff8c 
Call Trace:
 [<c0b946cc>] __down+0x0/0x1d6
 [<c0124522>] call_console_drivers+0x72/0x138
 [<c011ee6a>] default_wake_function+0x0/0x10
 [<c0124ac4>] release_console_sem+0x152/0x18a
 [<c0b94ab7>] __down_failed+0xb/0x14
 [<c05b7434>] .text.lock.radio_typhoon+0x5/0x29
 [<c05b70b0>] typhoon_mute+0x22/0x40
 [<c10bc61f>] typhoon_init+0xc7/0x12a
 [<c10908e2>] do_initcalls+0x2a/0xb8
 [<c10bc558>] typhoon_init+0x0/0x12a
 [<c0100394>] init+0x60/0x1c8
 [<c0100334>] init+0x0/0x1c8
 [<c01042b1>] kernel_thread_helper+0x5/0xc

Code: 0f 0b 78 00 42 be be c0 e9 82 fe ff ff 90 55 b8 00 e0 ff ff 
 <0>Kernel panic: Attempted to kill init!


--
~Randy

Re: sysfs warning + spinlock BUG in typhoon radio

[Andrew Morton]

"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
> Calling initcall 0xc10bc558: typhoon_init+0x0/0x12a()
> Typhoon Radio Card driver v0.1
> CLASS: registering class device: ID = 'radio2'
> class_hotplug - name = radio2
> videodev: "Typhoon Radio" has no release callback. Please fix your driver for proper sysfs support, see http://lwn.net/Articles/36850/
> radio-typhoon: port 0x316.
> radio-typhoon: mute frequency is 87500 kHz.
> eip: c0b946cc
> ------------[ cut here ]------------
> kernel BUG at include/asm/spinlock.h:120!

Does this fix?


diff -puN drivers/media/radio/radio-typhoon.c~typhoon-locking-fix drivers/media/radio/radio-typhoon.c
--- 25/drivers/media/radio/radio-typhoon.c~typhoon-locking-fix	Fri May 14 16:26:46 2004
+++ 25-akpm/drivers/media/radio/radio-typhoon.c	Fri May 14 16:28:29 2004
@@ -326,7 +326,6 @@ static int __init typhoon_init(void)
 		return -EINVAL;
 	}
 	typhoon_unit.iobase = io;
-	init_MUTEX(&typhoon_unit.lock);
 
 	if (mutefreq < 87000 || mutefreq > 108500) {
 		printk(KERN_ERR "radio-typhoon: You must set a frequency (in kHz) used when muting the card,\n");
@@ -337,6 +336,7 @@ static int __init typhoon_init(void)
 #endif /* MODULE */
 
 	printk(KERN_INFO BANNER);
+	init_MUTEX(&typhoon_unit.lock);
 	io = typhoon_unit.iobase;
 	if (!request_region(io, 8, "typhoon")) {
 		printk(KERN_ERR "radio-typhoon: port 0x%x already in use\n",

_

Re: sysfs warning + spinlock BUG in typhoon radio

[Randy.Dunlap]

On Fri, 14 May 2004 16:29:19 -0700 Andrew Morton wrote:

| "Randy.Dunlap" <rddunlap@osdl.org> wrote:
| >
| > Calling initcall 0xc10bc558: typhoon_init+0x0/0x12a()
| > Typhoon Radio Card driver v0.1
| > CLASS: registering class device: ID = 'radio2'
| > class_hotplug - name = radio2
| > videodev: "Typhoon Radio" has no release callback. Please fix your driver for proper sysfs support, see http://lwn.net/Articles/36850/
| > radio-typhoon: port 0x316.
| > radio-typhoon: mute frequency is 87500 kHz.
| > eip: c0b946cc
| > ------------[ cut here ]------------
| > kernel BUG at include/asm/spinlock.h:120!
| 
| Does this fix?
| 
| 
| diff -puN drivers/media/radio/radio-typhoon.c~typhoon-locking-fix drivers/media/radio/radio-typhoon.c
| --- 25/drivers/media/radio/radio-typhoon.c~typhoon-locking-fix	Fri May 14 16:26:46 2004
| +++ 25-akpm/drivers/media/radio/radio-typhoon.c	Fri May 14 16:28:29 2004
| @@ -326,7 +326,6 @@ static int __init typhoon_init(void)
|  		return -EINVAL;
|  	}
|  	typhoon_unit.iobase = io;
| -	init_MUTEX(&typhoon_unit.lock);
|  
|  	if (mutefreq < 87000 || mutefreq > 108500) {
|  		printk(KERN_ERR "radio-typhoon: You must set a frequency (in kHz) used when muting the card,\n");
| @@ -337,6 +336,7 @@ static int __init typhoon_init(void)
|  #endif /* MODULE */
|  
|  	printk(KERN_INFO BANNER);
| +	init_MUTEX(&typhoon_unit.lock);
|  	io = typhoon_unit.iobase;
|  	if (!request_region(io, 8, "typhoon")) {
|  		printk(KERN_ERR "radio-typhoon: port 0x%x already in use\n",
| 
| _


Yes, that fixes the spinlock BUG.  Thanks.

I'll look at the other piece of it later/weekend:
|| videodev: "Typhoon Radio" has no release callback. Please fix your driver for proper sysfs support, see http://lwn.net/Articles/36850/
since this is still there.

--
~Randy