mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Cef (LKML)" <cef-lkml@optusnet.com.au>
To: linux-kernel@vger.kernel.org
Cc: "Randy.Dunlap" <rddunlap@osdl.org>
Subject: Re: [announce/OT] kerneltop ver. 0.7
Date: Mon, 24 May 2004 15:53:42 +1000	[thread overview]
Message-ID: <200405241553.44114.cef-lkml@optusnet.com.au> (raw)
In-Reply-To: <20040523215027.5dc99711.rddunlap@osdl.org>

On Mon, 24 May 2004 14:50, Randy.Dunlap wrote:
> just a little note about kerneltop...
>
> 'kerneltop' is similar to 'top', but shows only kernel function usage
> (modules not included).

Looks good! A few suggestions....

Might want to add support for /boot/System.map containing the version number 
(eg: /boot/System.map-`uname -r` ), if /boot/System.map doesn't exist, before 
just dropping out with an error.

For clarity, you might want to invert the "address  function ....." line to 
separate the header from the actual displayed data (like top does).

Having the total up in the header instead of at the end of the data might also 
be useful (eg: next to ticks perhaps?) as it's really a waste of a display 
line for 1 number.

Also a little more verbosity in the error messages would be good. 

eg:
 /proc/profile not found:
 You need to enable profiling support in your kernel to use kerneltop
 /proc/profile Permission Denied:
 You need to be root to run kerneltop

Hope these comments are useful.

-- 
 Stuart Young (aka Cef)
 cef-lkml@optusnet.com.au is for LKML and related email only

  parent reply	other threads:[~2004-05-24  5:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-24  4:50 Randy.Dunlap
2004-05-24  5:31 ` William Lee Irwin III
2004-05-24  9:55   ` Cef (LKML)
2004-05-24 21:49     ` Randy.Dunlap
2004-05-24 21:47   ` Randy.Dunlap
2004-05-24  5:53 ` Cef (LKML) [this message]
2004-05-24  6:00   ` William Lee Irwin III
2004-05-24  7:18     ` Cef (LKML)
2004-05-25 19:12     ` Pavel Machek
2004-05-24 23:20 Albert Cahalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405241553.44114.cef-lkml@optusnet.com.au \
    --to=cef-lkml@optusnet.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®