From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@suse.de>,
weigand@i1.informatik.uni-erlangen.de, gcc@gcc.gnu.org,
linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com
Subject: Re: Linux 2.6 nanosecond time stamp weirdness breaks GCC build
Date: Mon, 7 Jun 2004 18:03:33 +0200 [thread overview]
Message-ID: <20040607160333.GA3521@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20040401163715.3592cedc.akpm@osdl.org>
On Thu, 1 April 2004 16:37:15 -0800, Andrew Morton wrote:
>
> I think this will cause the inode timestamps to keep on creeping forwards.
>
> How about in ext3_read_inode() you do:
>
> inode->i_atime.tv_sec = le32_to_cpu(raw_inode->i_atime);
> inode->i_ctime.tv_sec = le32_to_cpu(raw_inode->i_ctime);
> inode->i_mtime.tv_sec = le32_to_cpu(raw_inode->i_mtime);
> - inode->i_atime.tv_nsec = inode->i_ctime.tv_nsec = inode->i_mtime.tv_nsec = 0;
> + inode->i_atime.tv_nsec = inode->i_ctime.tv_nsec = inode->i_mtime.tv_nsec = 999999999;
Coming in way too late, how about changing the other end? Each
filesystem provides a new function that transforms high resolution
time into whatever the filesystem can store. If the function is NULL,
we use a sane default like above.
- inode->i_atime.tv_nsec = inode->i_ctime.tv_nsec = inode->i_mtime.tv_nsec = 0;
If the user never sees the high resolution in the first place, we
don't need to play guessing games later, after data has been flushed
from the page cache.
Jörn
--
The competent programmer is fully aware of the strictly limited size of
his own skull; therefore he approaches the programming task in full
humility, and among other things he avoids clever tricks like the plague.
-- Edsger W. Dijkstra
next prev parent reply other threads:[~2004-06-07 16:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-01 19:28 Ulrich Weigand
2004-04-01 20:09 ` Andi Kleen
2004-04-01 20:39 ` Daniel Jacobowitz
2004-04-01 20:46 ` Andi Kleen
2004-04-01 21:01 ` Ulrich Weigand
2004-04-01 21:44 ` Andi Kleen
2004-04-01 22:39 ` Joe Buck
2004-04-01 22:44 ` Paul Jarc
2004-04-01 22:48 ` Ulrich Weigand
2004-04-01 23:58 ` Joe Buck
2004-04-02 0:13 ` Daniel Jacobowitz
2004-04-02 0:02 ` Jamie Lokier
2004-04-02 0:35 ` Paul Eggert
2004-04-02 1:14 ` Jamie Lokier
2004-04-02 7:57 ` James H. Cloos Jr.
2004-04-02 9:22 ` Paul Eggert
2004-04-02 16:23 ` Jamie Lokier
2004-04-02 20:45 ` Paul Eggert
2004-04-02 21:07 ` Jamie Lokier
2004-04-02 21:56 ` Paul Eggert
2004-04-03 4:59 ` Andrew Pimlott
2004-04-02 0:37 ` Andrew Morton
2004-06-07 16:03 ` Jörn Engel [this message]
2004-04-01 21:13 ` Janis Johnson
2004-04-01 21:41 ` Ulrich Weigand
2004-04-02 0:30 ` Alan Modra
2004-04-02 9:05 ` P
2004-04-02 17:27 ` Alexandre Oliva
2004-04-01 20:51 Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040607160333.GA3521@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=gcc@gcc.gnu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=weigand@i1.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®