mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] remove 55 dead prototypes from include/acpi/acdisasm.h
@ 2004-07-20 23:04 Carl Spalletta
  0 siblings, 0 replies; 4+ messages in thread
From: Carl Spalletta @ 2004-07-20 23:04 UTC (permalink / raw)
  To: lkml; +Cc: en.brown, acpi-devel

This patch removes 55 prototypes of nonexistent functions.

N.B.
 Due to my inability to cut and paste the tab chars embedded in file to be patched (they are
 picked up as sequences of spaces), you must either a) 'unexpand --first-only' the enclosed patch
 to recover the tab chars from the original file, or b) apply with 'patch --ignore-whitespace'.
 The latter option can't hurt since we are only removing lines from the file, not adding.

Signed-off-by: Carl Spalletta <cspalletta@yahoo.com>

diff -ru /usr/src/linux-2.6.7-orig/include/acpi/acdisasm.h
/usr/src/linux-2.6.7-new/include/acpi/acdisasm.h
--- /usr/src/linux-2.6.7-orig/include/acpi/acdisasm.h   2004-06-15 22:19:26.000000000 -0700
+++ /usr/src/linux-2.6.7-new/include/acpi/acdisasm.h    2004-07-18 20:10:42.000000000 -0700
@@ -86,317 +86,14 @@
        u32                                 level,
        void                                *context);

-
-/*
- * dmwalk
- */
-
-void
-acpi_dm_walk_parse_tree (
-       union acpi_parse_object         *op,
-       asl_walk_callback               descending_callback,
-       asl_walk_callback               ascending_callback,
-       void                            *context);
-
-acpi_status
-acpi_dm_descending_op (
-       union acpi_parse_object         *op,
-       u32                             level,
-       void                            *context);
-
-acpi_status
-acpi_dm_ascending_op (
-       union acpi_parse_object         *op,
-       u32                             level,
-       void                            *context);
-
-
-/*
- * dmopcode
- */
-
-void
-acpi_dm_validate_name (
-       char                            *name,
-       union acpi_parse_object         *op);
-
-u32
-acpi_dm_dump_name (
-       char                            *name);
-
-void
-acpi_dm_unicode (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_disassemble (
-       struct acpi_walk_state          *walk_state,
-       union acpi_parse_object         *origin,
-       u32                             num_opcodes);
-
-void
-acpi_dm_namestring (
-       char                            *name);
-
-void
-acpi_dm_display_path (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_disassemble_one_op (
-       struct acpi_walk_state          *walk_state,
-       struct acpi_op_walk_info        *info,
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_decode_internal_object (
-       union acpi_operand_object       *obj_desc);
-
-u32
-acpi_dm_block_type (
-       union acpi_parse_object         *op);
-
-u32
-acpi_dm_list_type (
-       union acpi_parse_object         *op);
-
-acpi_status
-acpi_ps_display_object_pathname (
-       struct acpi_walk_state          *walk_state,
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_method_flags (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_field_flags (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_address_space (
-       u8                              space_id);
-
-void
-acpi_dm_region_flags (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_match_op (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_match_keyword (
-       union acpi_parse_object         *op);
-
-u8
-acpi_dm_comma_if_list_member (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_comma_if_field_member (
-       union acpi_parse_object         *op);
-
-
 /*
  * dmobject
  */

 void
-acpi_dm_decode_node (
-       struct acpi_namespace_node      *node);
-
-void
-acpi_dm_display_internal_object (
-       union acpi_operand_object       *obj_desc,
-       struct acpi_walk_state          *walk_state);
-
-void
-acpi_dm_display_arguments (
-       struct acpi_walk_state          *walk_state);
-
-void
-acpi_dm_display_locals (
-       struct acpi_walk_state          *walk_state);
-
-void
 acpi_dm_dump_method_info (
        acpi_status                     status,
        struct acpi_walk_state          *walk_state,
        union acpi_parse_object         *op);

-
-/*
- * dmbuffer
- */
-
-void
-acpi_is_eisa_id (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_eisa_id (
-       u32                             encoded_id);
-
-u8
-acpi_dm_is_unicode_buffer (
-       union acpi_parse_object         *op);
-
-u8
-acpi_dm_is_string_buffer (
-       union acpi_parse_object         *op);
-
-
-/*
- * dmresrc
- */
-
-void
-acpi_dm_disasm_byte_list (
-       u32                             level,
-       u8                              *byte_data,
-       u32                             byte_count);
-
-void
-acpi_dm_byte_list (
-       struct acpi_op_walk_info        *info,
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_resource_descriptor (
-       struct acpi_op_walk_info        *info,
-       u8                              *byte_data,
-       u32                             byte_count);
-
-u8
-acpi_dm_is_resource_descriptor (
-       union acpi_parse_object         *op);
-
-void
-acpi_dm_indent (
-       u32                             level);
-
-void
-acpi_dm_bit_list (
-       u16                             mask);
-
-void
-acpi_dm_decode_attribute (
-       u8                              attribute);
-
-/*
- * dmresrcl
- */
-
-void
-acpi_dm_io_flags (
-               u8                          flags);
-
-void
-acpi_dm_memory_flags (
-       u8                              flags,
-       u8                              specific_flags);
-
-void
-acpi_dm_word_descriptor (
-       struct asl_word_address_desc    *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_dword_descriptor (
-       struct asl_dword_address_desc   *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_qword_descriptor (
-       struct asl_qword_address_desc   *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_memory24_descriptor (
-       struct asl_memory_24_desc       *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_memory32_descriptor (
-       struct asl_memory_32_desc       *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_fixed_mem32_descriptor (
-       struct asl_fixed_memory_32_desc *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_generic_register_descriptor (
-       struct asl_general_register_desc *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_interrupt_descriptor (
-       struct asl_extended_xrupt_desc *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_vendor_large_descriptor (
-       struct asl_large_vendor_desc    *resource,
-       u32                             length,
-       u32                             level);
-
-
-/*
- * dmresrcs
- */
-
-void
-acpi_dm_irq_descriptor (
-       struct asl_irq_format_desc      *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_dma_descriptor (
-       struct asl_dma_format_desc      *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_io_descriptor (
-       struct asl_io_port_desc         *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_fixed_io_descriptor (
-       struct asl_fixed_io_port_desc   *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_start_dependent_descriptor (
-       struct asl_start_dependent_desc *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_end_dependent_descriptor (
-       struct asl_start_dependent_desc *resource,
-       u32                             length,
-       u32                             level);
-
-void
-acpi_dm_vendor_small_descriptor (
-       struct asl_small_vendor_desc    *resource,
-       u32                             length,
-       u32                             level);
-
-
 #endif  /* __ACDISASM_H__ */


^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [ACPI] [PATCH] remove 55 dead prototypes from include/acpi/acdisasm.h
@ 2004-07-21 20:30 Moore, Robert
  2004-07-21 22:35 ` Carl Spalletta
  0 siblings, 1 reply; 4+ messages in thread
From: Moore, Robert @ 2004-07-21 20:30 UTC (permalink / raw)
  To: Carl Spalletta, lkml; +Cc: en.brown, acpi-devel

These aren't nonexistent functions, they are part of the AML
disassembler (which is not always configured into the kernel)




> -----Original Message-----
> From: acpi-devel-admin@lists.sourceforge.net [mailto:acpi-devel-
> admin@lists.sourceforge.net] On Behalf Of Carl Spalletta
> Sent: Tuesday, July 20, 2004 4:05 PM
> To: lkml
> Cc: en.brown@intel.com; acpi-devel@lists.sourceforge.net
> Subject: [ACPI] [PATCH] remove 55 dead prototypes from
> include/acpi/acdisasm.h
> 
> This patch removes 55 prototypes of nonexistent functions.
> 
> N.B.
>  Due to my inability to cut and paste the tab chars embedded in file
to be
> patched (they are
>  picked up as sequences of spaces), you must either a) 'unexpand
--first-
> only' the enclosed patch
>  to recover the tab chars from the original file, or b) apply with
'patch
> --ignore-whitespace'.
>  The latter option can't hurt since we are only removing lines from
the
> file, not adding.
> 
> Signed-off-by: Carl Spalletta <cspalletta@yahoo.com>
> 
> diff -ru /usr/src/linux-2.6.7-orig/include/acpi/acdisasm.h
> /usr/src/linux-2.6.7-new/include/acpi/acdisasm.h
> --- /usr/src/linux-2.6.7-orig/include/acpi/acdisasm.h   2004-06-15
> 22:19:26.000000000 -0700
> +++ /usr/src/linux-2.6.7-new/include/acpi/acdisasm.h    2004-07-18
> 20:10:42.000000000 -0700
> @@ -86,317 +86,14 @@
>         u32                                 level,
>         void                                *context);
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] remove 55 dead prototypes from include/acpi/acdisasm.h
@ 2004-07-22 20:48 Moore, Robert
  0 siblings, 0 replies; 4+ messages in thread
From: Moore, Robert @ 2004-07-22 20:48 UTC (permalink / raw)
  To: Carl Spalletta, lkml; +Cc: Brown, Len, acpi-devel, Yu, Luming


The ACPI CA AML debugger and disassembler haven't been integrated into
the kernel yet, but development is underway and almost complete.


> -----Original Message-----
> From: Carl Spalletta [mailto:cspalletta@yahoo.com]
> Sent: Wednesday, July 21, 2004 3:36 PM
> To: Moore, Robert; lkml
> Cc: Brown, Len; acpi-devel@lists.sourceforge.net
> Subject: RE: [PATCH] remove 55 dead prototypes from
> include/acpi/acdisasm.h
> 
> --- "Moore, Robert" <robert.moore@intel.com> wrote:
> > These aren't nonexistent functions, they are part of the AML
> > disassembler (which is not always configured into the kernel)
> 
>   With respect, I cannot find the functions listed below anywhere in
> the kernel.org kernel.  Where are they?  Given that they are not
present,
> you should consider either contributing them to the mainline kernel
source
> tree, or removing their prototypes.
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] remove 55 dead prototypes from include/acpi/acdisasm.h
@ 2004-07-23  7:47 Carl Spalletta
  0 siblings, 0 replies; 4+ messages in thread
From: Carl Spalletta @ 2004-07-23  7:47 UTC (permalink / raw)
  To: lkml


>> -----Original Message-----
>> From: Carl Spalletta [mailto:cspalletta@yahoo.com]
>> Sent: Wednesday, July 21, 2004 3:36 PM
>> To: Moore, Robert; lkml
>> Cc: Brown, Len; acpi-devel@lists.sourceforge.net
>> Subject: RE: [PATCH] remove 55 dead prototypes from include/acpi/acdisasm.h

>>> --- "Moore, Robert" <robert.moore@intel.com> wrote:
>>> These aren't nonexistent functions, they are part of the AML
>>> disassembler (which is not always configured into the kernel)

>> With respect, I cannot find the functions listed below anywhere in
>> the kernel.org kernel.  Where are they?

> --- "Moore, Robert" <robert.moore@intel.com> wrote:
> Subject: RE: [PATCH] remove 55 dead prototypes from include/acpi/acdisasm.h
> Date: Thu, 22 Jul 2004 13:48:12 -0700

> The ACPI CA AML debugger and disassembler haven't been integrated into
> the kernel yet, but development is underway and almost complete.

Yes, it is technically correct to say it "is not always configured into the kernel"
but it would be equally correct, and less misleading to say it is "never configured
into the kernel, because the code is not there".


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-07-23  7:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-07-20 23:04 [PATCH] remove 55 dead prototypes from include/acpi/acdisasm.h Carl Spalletta
2004-07-21 20:30 [ACPI] " Moore, Robert
2004-07-21 22:35 ` Carl Spalletta
2004-07-22 20:48 Moore, Robert
2004-07-23  7:47 Carl Spalletta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®