[PATCH] fix cc-version breakage

[PATCH] fix cc-version breakage

[Jesse Barnes]

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]

Looks like someone forgot to use $(shell ...) on the cc-version function?

Jesse

[-- Attachment #2: cc-version-fix.patch --]
[-- Type: text/plain, Size: 496 bytes --]

===== Makefile 1.522 vs edited =====
--- 1.522/Makefile	2004-08-23 23:59:52 -07:00
+++ edited/Makefile	2004-08-24 16:39:46 -07:00
@@ -279,8 +279,8 @@
 
 # cc-version
 # Usage gcc-ver := $(call cc-version $(CC))
-cc-version = $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
-              $(if $(1), $(1), $(CC))
+cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
+              $(if $(1), $(1), $(CC)))
 
 
 # Look for make include files relative to root of kernel src

Re: [PATCH] fix cc-version breakage

[Jesse Barnes]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

On Tuesday, August 24, 2004 4:42 pm, Jesse Barnes wrote:
> Looks like someone forgot to use $(shell ...) on the cc-version function?

Actually, this is a little nicer (look ma, no linewraps!) if we can make 
gcc-version.sh executable.

Jesse

[-- Attachment #2: cc-version-fix-2.patch --]
[-- Type: text/plain, Size: 463 bytes --]

===== Makefile 1.522 vs edited =====
--- 1.522/Makefile	2004-08-23 23:59:52 -07:00
+++ edited/Makefile	2004-08-24 16:46:44 -07:00
@@ -279,8 +279,7 @@
 
 # cc-version
 # Usage gcc-ver := $(call cc-version $(CC))
-cc-version = $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
-              $(if $(1), $(1), $(CC))
+cc-version = $(shell $(srctree)/scripts/gcc-version.sh $(if $(1), $(1), $(CC)))
 
 
 # Look for make include files relative to root of kernel src

Re: [PATCH] fix cc-version breakage

[Sam Ravnborg]

On Tue, Aug 24, 2004 at 04:48:49PM -0700, Jesse Barnes wrote:
> 
> Actually, this is a little nicer (look ma, no linewraps!) if we can make 
> gcc-version.sh executable.
It is no possible for all users to guarantee this, therefore the rule of thumb
for the kernel is to always use CONFIG_SHELL.

Btw - patch already sent to Linus and lkml.

	Sam

Re: [PATCH] fix cc-version breakage

[Jesse Barnes]

On Tuesday, August 24, 2004 9:43 pm, Sam Ravnborg wrote:
> On Tue, Aug 24, 2004 at 04:48:49PM -0700, Jesse Barnes wrote:
> > Actually, this is a little nicer (look ma, no linewraps!) if we can make
> > gcc-version.sh executable.
>
> It is no possible for all users to guarantee this, therefore the rule of
> thumb for the kernel is to always use CONFIG_SHELL.
>
> Btw - patch already sent to Linus and lkml.

Ok, I thought the problem seemed familiar, and now I see the fix in the BK 
tree.  Thanks.

Jesse