drm fixup 1/2 - missing bus_address assignment

drm fixup 1/2 - missing bus_address assignment

[Dave Airlie]

This is a series of two minor patches for the DRM, one fixes a missing
bus_address and the other from Arjan optimises some access in the i8x0
drivers..


Patch from Tom Arbuckle for missing bus_address

Signed-off-by: Dave Airlie <airlied@linux.ie>

diff -Nru a/drivers/char/drm/drm_bufs.h b/drivers/char/drm/drm_bufs.h
--- a/drivers/char/drm/drm_bufs.h	Sat Aug 28 00:02:27 2004
+++ b/drivers/char/drm/drm_bufs.h	Sat Aug 28 00:02:28 2004
@@ -691,6 +691,7 @@
 			buf->used    = 0;
 			buf->offset  = (dma->byte_count + byte_count + offset);
 			buf->address = (void *)(page + offset);
+			buf->bus_address = virt_to_bus(buf->address);
 			buf->next    = NULL;
 			buf->waiting = 0;
 			buf->pending = 0;

Re: drm fixup 1/2 - missing bus_address assignment

[Christoph Hellwig]

On Fri, Aug 27, 2004 at 03:12:30PM +0100, Dave Airlie wrote:
> +			buf->bus_address = virt_to_bus(buf->address);

this iw wrong.  never use virt_to_bus in new code and whenever you see it
in old code get rid of it.

Re: drm fixup 1/2 - missing bus_address assignment

[Dave Airlie]

> > +			buf->bus_address = virt_to_bus(buf->address);
>
> this iw wrong.  never use virt_to_bus in new code and whenever you see it
> in old code get rid of it.
>

Is there an alternative or do I just dump it? I think we only use the
bus_address for debugging in /proc and I don't think many people actually
have used it ..

Dave.

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person

Re: drm fixup 1/2 - missing bus_address assignment

[David S. Miller]

On Sat, 28 Aug 2004 00:55:32 +0100 (IST)
Dave Airlie <airlied@linux.ie> wrote:

> > > +			buf->bus_address = virt_to_bus(buf->address);
> >
> > this iw wrong.  never use virt_to_bus in new code and whenever you see it
> > in old code get rid of it.
> >
> 
> Is there an alternative or do I just dump it? I think we only use the
> bus_address for debugging in /proc and I don't think many people actually
> have used it ..

You really have to use the defined DMA apis for stuff like this.

I was going to bark about this too.

Check out Documentation/DMA-mapping.txt and friends.

Re: drm fixup 1/2 - missing bus_address assignment

[Dave Airlie]

> You really have to use the defined DMA apis for stuff like this.
>
> I was going to bark about this too.
>
> Check out Documentation/DMA-mapping.txt and friends.

I'll check it out and submit a patches ripping them all out .. there's a
couple in the mga...

Dave.

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person